From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Jan Kasprzak <kas@fi.muni.cz>
Subject: Re: [PATCH 1/1] Char: moxa, fix refcounting in moxa_poll_port
Date: Sun, 15 Mar 2009 12:52:00 +0100 [thread overview]
Message-ID: <49BCEBE0.4080802@gmail.com> (raw)
In-Reply-To: <20090315105530.6f1782be@lxorguk.ukuu.org.uk>
Restoring CCs.
On 15.3.2009 11:55, Alan Cox wrote:
> On Sun, 15 Mar 2009 10:36:08 +0100
> Jiri Slaby<jirislaby@gmail.com> wrote:
>
>> There is missing tty_kref_put on some paths in moxa_poll_port,
>> although the reference is always taken. Fix it.
>>
>> Signed-off-by: Jiri Slaby<jirislaby@gmail.com>
>> Reported-by: Jan 'Yenya' Kasprzak<kas@fi.muni.cz>
>> Cc: Alan Cox<alan@lxorguk.ukuu.org.uk>
>
> Acked-by: Alan Cox<alan@lxorguk.ukuu.org.uk>
BTW the same sha, the change in isicom_shutdown_port doesn't seem to be
quite right too. Well, the change itself is, but not in the code
context. The tty is used even after tty_port_tty_set(NULL). This is
wrong, isn't it?
next prev parent reply other threads:[~2009-03-15 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 21:36 MOXA I/O errors on 2.6.28+ Jan Kasprzak
2009-03-14 21:42 ` Alan Cox
2009-03-14 22:41 ` Jan Kasprzak
2009-03-15 9:31 ` Jiri Slaby
2009-03-15 9:36 ` [PATCH 1/1] Char: moxa, fix refcounting in moxa_poll_port Jiri Slaby
[not found] ` <20090315105530.6f1782be@lxorguk.ukuu.org.uk>
2009-03-15 11:52 ` Jiri Slaby [this message]
2009-03-15 9:37 ` Jiri Slaby
2009-03-15 15:25 ` Jan Yenya Kasprzak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BCEBE0.4080802@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kas@fi.muni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.