From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: print out in e820_update_range()
Date: Sun, 15 Mar 2009 11:03:33 -0700 [thread overview]
Message-ID: <49BD42F5.7070808@kernel.org> (raw)
In-Reply-To: <20090315080717.GA18978@elte.hu>
Ingo Molnar wrote:
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
>> Impact: to find crazy calling
>>
>> try to print out more info, to catch wrong calling
>
> Could we detect incorrect parameters more directly as well, via
> a check and a panic()?
only valid checking seems to be
virt_to_phys(_text), virt_to_phys(_end)
if (new_type == E820_RESERVED && start >= virt_to_phys(_text) && start <= virt_to_phys(_end))
panic("try to update to e820 range for kernel to RESERVED!");
YH
next prev parent reply other threads:[~2009-03-15 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 7:59 [PATCH] x86: print out in e820_update_range() Yinghai Lu
2009-03-15 8:07 ` Ingo Molnar
2009-03-15 18:03 ` Yinghai Lu [this message]
2009-03-15 18:55 ` Ingo Molnar
2009-03-15 9:54 ` [tip:x86/mm] x86: print out more info " Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BD42F5.7070808@kernel.org \
--to=yinghai@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.