All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] vnc: shared buffer: skip some optimizations.
Date: Mon, 16 Mar 2009 11:17:32 +0000	[thread overview]
Message-ID: <49BE354C.7010806@eu.citrix.com> (raw)
In-Reply-To: <49BE32CB.70405@redhat.com>

Gerd Hoffmann wrote:

> (b) doesn't set the 'to send' bit.  It clears the 'to send' bit for
> screen areas which are not modified.
> 
> You have two possible effects:
>  * screen update is sent twice.
>  * screen update is *not* sent.
> 
> The second causes persistent screen corruptions, it is not fixed up by
> the next refresh.
> 
> Wanna have a screen shot?
> 

Ok, ok I believe you :)

Your patch is fine for me then.

  reply	other threads:[~2009-03-16 11:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11 14:43 [Qemu-devel] [PATCH] vnc: shared buffer: skip some optimizations Gerd Hoffmann
2009-03-11 15:43 ` Anthony Liguori
2009-03-12 19:58   ` Gerd Hoffmann
2009-03-13 12:03     ` Stefano Stabellini
2009-03-16  8:35       ` Gerd Hoffmann
2009-03-16 10:27         ` Stefano Stabellini
2009-03-16 11:06           ` Gerd Hoffmann
2009-03-16 11:17             ` Stefano Stabellini [this message]
2009-03-12 14:16 ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BE354C.7010806@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.