From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 3/3] netfilter: ctnetlink: move event reporting for new entries outside the lock Date: Mon, 16 Mar 2009 15:24:25 +0100 Message-ID: <49BE6119.2050105@trash.net> References: <20090305160714.13755.83435.stgit@Decadence> <20090305160759.13755.64802.stgit@Decadence> <49BE60D4.9040902@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from stinky.trash.net ([213.144.137.162]:46317 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752957AbZCPOY2 (ORCPT ); Mon, 16 Mar 2009 10:24:28 -0400 In-Reply-To: <49BE60D4.9040902@trash.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Patrick McHardy wrote: > Pablo Neira Ayuso wrote: >> This patch moves the event reporting outside the lock section. With >> this patch, the creation and update of entries is homogeneous from >> the event reporting perspective. Moreover, as the event reporting is >> done outside the lock section, the netlink broadcast delivery can >> benefit of the yield() call under congestion. > > This one doesn't apply cleanly, probably because of the missing > netlink_set_err patch. I've pushed out my current nf-next tree, > please rediff against that tree. It might also have been ordering, let me try again :)