From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank van der Linden Subject: Re: Re: [RFC] RAS(Part II)--MCA enalbing in XEN Date: Mon, 16 Mar 2009 10:27:06 -0600 Message-ID: <49BE7DDA.4020206@Sun.COM> References: <200903051828.33638.Christoph.Egger@amd.com> <200903102008.03034.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT Return-path: In-reply-to: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Jiang, Yunhong" Cc: Christoph Egger , "xen-devel@lists.xensource.com" , "Ke, Liping" , Gavin Maltby , Keir Fraser , "Kleen, Andi" List-Id: xen-devel@lists.xenproject.org Jiang, Yunhong wrote: > Christoph Egger wrote: >> I think, we should mark the 'struct mcinfo_global' as a kind >> of header for >> each error. All following information describe the error >> (including the >> follow-up errors) and all recover actions. This gives us the >> flexibility >> to get as many information as possible and allows to do >> as many recover actions as necessary instead of just one. > > I think your original proposal can also meet such purpose, i.e. include the mc_recover_info and we still need pass all mc_bacnk infor to dom0 for telemetry. If you prefer this one, can you please define the interface? Gavin/Frank, do you have any idea for this changes? Sorry about the slow reply. Our changes to the MCE code (to combine the AMD and Intel code as much as possible, and use a transactional approach to the telemetry) already pretty much uses mc_global as a header. With our code, dom0 retrieves one mcinfo structure, with one global structure (which always comes first, but that's not required). In other words, using mc_global as kind of a header to the mcinfo data is fine, since we're already doing that. And, since we're talking about transactions with one mcinfo structure at a time (with one mc_global structure), the recover_info structures can be separate from the bank structures. - Frank