From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: (pull) pending patches Date: Mon, 16 Mar 2009 17:44:18 +0100 Message-ID: <49BE81E2.2030805@trash.net> References: <49BE0FF3.5090906@netfilter.org> <49BE567F.1020704@trash.net> <49BE574E.8070202@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Pablo Neira Ayuso , Netfilter Developer Mailing List To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:50645 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754440AbZCPQoX (ORCPT ); Mon, 16 Mar 2009 12:44:23 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > On Monday 2009-03-16 14:42, Patrick McHardy wrote: > >> Jan Engelhardt wrote: >>> On Monday 2009-03-16 14:39, Patrick McHardy wrote: >>> >>>> We used to have ip_nat_range(_compat) for compatibility for that reason >>>> IIRC. The kernel doesn't need anymore, so I think userspace should carry >>>> a copy as long as ipt_SAME is still supported. >>>> >>> But that only makes it harder to keep files in sync :-/ >> There is nothing to keep in sync, ipt_SAME doesn't exist in the kernel >> anymore. And a structure kept purely to maintain compatibility with old >> kernels will obviously never change. >> > All NAT modules -- libipt_DNAT, SNAT, MASQUERADE, NETMAP, REDIRECT -- > use struct nf_nat_multi_range, which is also only in nf_nat.h. Indeed, that one should be exported. But in order to that is should be moved to include/linux/netfilter instead of using include/net includes in userspace.