Git SRC_TARBALL_STASH filename

[Douglas Royds <douglas.royds@tait.co.nz>]

Working behind a firewall that doesn't allow Git access (except over 
http). I've set SRC_TARBALL_STASH so that we only have to download the 
appropriate source tarball (manually) once.

While building mtd-utils, BitBake is trying to fetch from the tarball stash:

    http://.../git_git.infradead.org.mtd-utils.git.tar.gz

Instead of:

    http://.../git_git.infradead.org.mtd-utils.git_ea429635388f7bb53f62c41ec3d5ccf5fa207370.tar.gz

The following patch appears to do the job, but I'm not confident this is 
the right fix. I notice that all the other fetchers use ud.localfile, 
which already has the correct filename.

Index: lib/bb/fetch/git.py
===================================================================
--- lib/bb/fetch/git.py    (revision 16639)
+++ lib/bb/fetch/git.py    (working copy)
@@ -73,7 +73,7 @@
 
         gitsrcname = '%s%s' % (ud.host, ud.path.replace('/', '.'))
 
-        repofilename = 'git_%s.tar.gz' % (gitsrcname)
+        repofilename = 'git_%s_%s.tar.gz' % (gitsrcname, ud.tag)
         repofile = os.path.join(data.getVar("DL_DIR", d, 1), repofilename)
         repodir = os.path.join(data.expand('${GITDIR}', d), gitsrcname)


Suggestions?
Douglas.






=======================================================================
This email, including any attachments, is only for the intended
addressee.  It is subject to copyright, is confidential and may be
the subject of legal or other privilege, none of which is waived or
lost by reason of this transmission.
If the receiver is not the intended addressee, please accept our
apologies, notify us by return, delete all copies and perform no
other act on the email.
Unfortunately, we cannot warrant that the email has not been
 altered or corrupted during transmission.
=======================================================================