From: Michael J Gruber <git@drmicha.warpmail.net>
To: "David J. Mellor" <dmellor@whistlingcat.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH 1/4] Documentation: minor grammatical fixes in git-archive.txt.
Date: Tue, 17 Mar 2009 10:18:17 +0100 [thread overview]
Message-ID: <49BF6AD9.4020207@drmicha.warpmail.net> (raw)
In-Reply-To: <1237270577-17261-1-git-send-email-dmellor@whistlingcat.com>
David J. Mellor venit, vidit, dixit 17.03.2009 07:16:
> Signed-off-by: David J. Mellor <dmellor@whistlingcat.com>
[replying to the first patch since there's no cover letter]
For patches like this one, I wish we had a robust way of using "git
format-patch --color-words"... "Robust" as in "working for most
recipients + git-am".
So I applied your series locally and checked the --color-words diff.
Nice work, all 4 of them!
One minor reoccurring issue is the following type of construct:
###
The good/bad input is logged, and:
------------
$ git bisect log
------------
shows what you have done so far.
###
The first line is not a complete sentence. Neither is the last one,
which you have to read together with the code inset (that's fine), which
on the other belongs to the sentence started in line 1.
All of the above constitutes 1 sentence and should not be chopped in
parts by the colon.
I know this construct is somewhat common, but I don't think it is
correct. In any case it disrupts the reading flow. [In fact, that
disruption is the very reason why it is sometimes used in the middle of
a written sentence: as a substitute for the rhetoric element "pause".]
In the example above your patch introduces it, in other places it has
been used before. So this might my an opportunity to get rid of it
consistently ;)
Michael
next prev parent reply other threads:[~2009-03-17 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 6:16 [PATCH 1/4] Documentation: minor grammatical fixes in git-archive.txt David J. Mellor
2009-03-17 6:16 ` [PATCH 2/4] Documentation: reworded the "Description" section of git-blame.txt David J. Mellor
2009-03-14 22:56 ` [PATCH 2/4] Documentation: reworded the "Description" section of git-bisect.txt David J. Mellor
2009-03-18 3:32 ` David J. Mellor
2009-03-17 6:16 ` [PATCH 3/4] Documentation: minor grammatical fixes in git-blame.txt David J. Mellor
2009-03-17 6:16 ` [PATCH 4/4] Documentation: minor grammatical fixes in git-branch.txt David J. Mellor
2009-03-18 5:41 ` [PATCH 2/4] Documentation: reworded the "Description" section of git-blame.txt Junio C Hamano
2009-03-17 9:18 ` Michael J Gruber [this message]
2009-03-18 2:54 ` [PATCH 1/4] Documentation: minor grammatical fixes in git-archive.txt David J. Mellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BF6AD9.4020207@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=dmellor@whistlingcat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.