From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] r6349 broke Commander Keen 4 ;-(
Date: Tue, 17 Mar 2009 10:23:40 +0000 [thread overview]
Message-ID: <49BF7A2C.7020707@eu.citrix.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0903170206040.4644@linmac.oyster.ru>
malc wrote:
> On Mon, 16 Mar 2009, Robert Riebisch wrote:
>
>> Hi!
>>
>> When running Commander Keen 4 (<ftp://ftp.3drealms.com/share/4keen.zip>)
>> in DOS only the left half of the VGA screen is shown on the SDL interface.
>>
>> By doing lots of builds I narrowed the problem down to
>> <http://svn.savannah.gnu.org/viewvc?view=rev&root=qemu&revision=6349> by
>> Stefano Stabellini.
>
> 6349 is indeed what broke stuff, the code was moved (why?) and uses
> disp_width that could be modified later..
Good catch! Thanks to Robert Riebisch for the extremely good bug report.
The code was moved because the DisplaySurface color depth could change
as a consequence of qemu_create_displaysurface_from or
qemu_console_resize: rgb_to_pixel depends on the DysplaySurface depth
and update_palette[16,256] depends on rgb_to_pixel.
Therefore your patch is fine because fixes the problem keeping the
benefit of the original patch.
prev parent reply other threads:[~2009-03-17 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 21:57 [Qemu-devel] r6349 broke Commander Keen 4 ;-( Robert Riebisch
2009-03-16 22:33 ` Rick Vernam
2009-03-16 23:08 ` malc
2009-03-17 10:23 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BF7A2C.7020707@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.