From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: [PATCH] (resend) Use vnc-listen setting specified in xend config file Date: Tue, 17 Mar 2009 10:15:10 -0600 Message-ID: <49BFCC8E.4030300@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090002070706020503090100" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------090002070706020503090100 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit My mailer botched original patch as it exceeded 80 columns - apologies. If domU frame buffer configuration has no vnclisten attribute set, use the global vnc-listen address specified in xend configuration file when updating vfb location. Currently the hardcoded value 'localhost' is used. Example: User specifies (vnc-listen '192.168.0.1') in xend configuration file and does not have vnclisten set in domU configuration. Starting a domU with this configuration results in vfb location containing (location localhost:5900) instead of (location 192.168.0.1:5900) Signed-off-by: Jim Fehlig --------------090002070706020503090100 Content-Type: text/x-patch; name="xend-vnclisten.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="xend-vnclisten.patch" diff -r 0e1449d6f231 tools/python/xen/xend/XendDomainInfo.py --- a/tools/python/xen/xend/XendDomainInfo.py Fri Mar 13 10:09:25 2009 +0000 +++ b/tools/python/xen/xend/XendDomainInfo.py Mon Mar 16 13:17:03 2009 -0600 @@ -1410,7 +1410,8 @@ class XendDomainInfo: for dev_uuid, (dev_type, dev_info) in self.info['devices'].items(): if dev_type == 'vfb': old_location = dev_info.get('location') - listen_host = dev_info.get('vnclisten', 'localhost') + listen_host = dev_info.get('vnclisten', \ + XendOptions.instance().get_vnclisten_address()) new_location = '%s:%s' % (listen_host, str(vnc_port)) if old_location == new_location: break --------------090002070706020503090100 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------090002070706020503090100--