From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
srostedt@redhat.com, tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/ftrace] ftrace: remove struct list_head from struct dyn_ftrace
Date: Wed, 18 Mar 2009 10:50:01 +0800 [thread overview]
Message-ID: <49C06159.9010704@cn.fujitsu.com> (raw)
In-Reply-To: <20090316124229.GB5096@nowhere>
Frederic Weisbecker wrote:
>
>
> May be I'm wrong. May be I misunderstood this patch.
> But I don't understand how flags can be used at the same time as a pointer
> and as a flag value.
>
When a new dyn_ftrace is added to ftrace_new_addrs list, the flag is 0,
it's always 0 until this dyn_ftrace is removed from the list, so we can
reuse the flag field. As Steven's suggest, using an union is better.
ftrace_convert_nops()
ftrace_record_ip() // allocate dyn_ftrace, and add it
// to ftrace_new_addrs list
ftrace_update_code() // remove it from ftrace_new_addrs.
Lai.
prev parent reply other threads:[~2009-03-18 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 9:51 [PATCH] ftace: remove struct list_head in struct dyn_ftrace Lai Jiangshan
2009-03-13 10:39 ` [tip:tracing/ftrace] ftrace: remove struct list_head from " Lai Jiangshan
2009-03-13 13:16 ` Steven Rostedt
2009-03-16 12:36 ` Frederic Weisbecker
2009-03-16 12:42 ` Frederic Weisbecker
2009-03-18 2:50 ` Lai Jiangshan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C06159.9010704@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.