All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata-core More robust parsing for multi_count(v3)
Date: Thu, 19 Mar 2009 09:23:35 +0900	[thread overview]
Message-ID: <49C19087.5000307@gmail.com> (raw)
In-Reply-To: <49C11ED4.2030307@rtr.ca>

Hello, Mark.

Mark Lord wrote:
> +            if (cnt && cnt <= max && (max & (max - 1)) == 0) {

Can you please include <linux/log2.h> and use is_power_of_2() instead?

Thanks.

-- 
tejun

  parent reply	other threads:[~2009-03-19  0:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 14:26 [PATCH] libata-core Use more robust parsing for multi_count Mark Lord
2009-03-18 14:32 ` Alan Cox
2009-03-18 15:06   ` Mark Lord
2009-03-18 15:13     ` Mark Lord
2009-03-18 17:09     ` Alan Cox
2009-03-18 15:58 ` Mark Lord
2009-03-18 16:18   ` [PATCH] libata-core More robust parsing for multi_count(v3) Mark Lord
2009-03-18 16:24     ` Mark Lord
2009-03-19  0:23     ` Tejun Heo [this message]
2009-03-19  0:25       ` Tejun Heo
2009-03-19 17:30         ` [PATCH] libata-core More robust parsing for multi_count(v4) Mark Lord
2009-03-19 17:32           ` [PATCH] libata-core More robust parsing for multi_count(v5) Mark Lord
2009-03-19 23:33             ` Tejun Heo
2009-03-20  3:37               ` Mark Lord
2009-03-20 13:13               ` Mark Lord
2009-03-20 13:14                 ` Mark Lord
2009-03-20 14:07                   ` Alan Cox
2009-03-20 15:36                     ` Mark Lord
2009-03-20 23:14                       ` Tejun Heo
2009-03-21  0:54                         ` Jeff Garzik
2009-03-21  2:17                           ` Tejun Heo
2009-03-21 13:54                             ` Mark Lord
2009-03-21 14:02                           ` Alan Cox
2009-03-21 14:59                             ` Mark Lord
2009-03-20 13:38                 ` Alan Cox
2009-04-12 15:10                 ` Mark Lord
2009-04-12 15:18                   ` Alan Cox
2009-04-12 15:31                     ` Jeff Garzik
2009-03-25  2:40             ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C19087.5000307@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.