From: Michal Simek <monstr@monstr.eu>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, john.williams@petalogix.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Microblaze linux support
Date: Thu, 19 Mar 2009 10:42:58 +0100 [thread overview]
Message-ID: <49C213A2.4040609@monstr.eu> (raw)
In-Reply-To: <20090319072256.GA5069@elte.hu>
Hi Ingo,
>> Hi all,
>>
>> I think that is the right time to send you next pack with
>> Microblaze support. It is seventh pack - some previous packs
>> was review by community and I hope there are not any big faults.
>
> I have not done a deep review, but there's a lot of avoidable easy
> style bugs in the patches. All the patches together, passed through
> scripts/checkpatch.pl give ~200 errors:
>
> total: 40 errors, 146 warnings, 15737 lines checked
>
> A quick look suggests that most of the warnings pinpoint real
> problems. (and you can ignore false positives)
I fixed coding style issue which was there. Some of them are false positive.
I don't want to disturb people with next big pack and next version that's why I
updated only branch on git (Patches has name microblaze_v8-pre)
Below is part of log with faults which are announcing with checkpatch.pl script
+ my comments. I remove patches without any fault.
Thanks for noticing me in cases where I am wrong.
Thanks,
Michal
>
> Thanks,
>
> Ingo
ERROR: spaces prohibited around that ':' (ctx:WxW)
#2588: FILE: arch/microblaze/kernel/prom_parse.c:637:
+ cells = prop ? *(u32 *)prop : of_n_addr_cells(dn);
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#2594: FILE: arch/microblaze/kernel/prom_parse.c:643:
+ cells = prop ? *(u32 *)prop : of_n_size_cells(dn);
^
total: 2 errors, 0 warnings, 2910 lines checked
0004-microblaze_v8-pre-Open-firmware-files.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
I think that this is correct coding style (Same for PowerPC)
-------------------------------------------------------------------------------------------
WARNING: do not add new typedefs
#127: FILE: arch/microblaze/include/asm/signal.h:107:
+typedef unsigned long old_sigset_t; /* at least 32 bits */
WARNING: do not add new typedefs
#129: FILE: arch/microblaze/include/asm/signal.h:109:
+typedef struct {
WARNING: do not add new typedefs
#161: FILE: arch/microblaze/include/asm/signal.h:141:
+typedef unsigned long sigset_t;
WARNING: do not add new typedefs
#178: FILE: arch/microblaze/include/asm/signal.h:158:
+typedef struct sigaltstack {
total: 0 errors, 4 warnings, 701 lines checked
0007-microblaze_v8-pre-Signal-support.patch has style problems, please review.
If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
False positive.
-------------------------------------------------------------------------------------------
WARNING: do not add new typedefs
#57: FILE: arch/microblaze/include/asm/module.h:35:
+typedef struct { volatile int counter; } module_t;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#57: FILE: arch/microblaze/include/asm/module.h:35:
+typedef struct { volatile int counter; } module_t;
WARNING: externs should be avoided in .c files
#92: FILE: arch/microblaze/kernel/microblaze_ksyms.c:27:
+extern void __ashldi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#93: FILE: arch/microblaze/kernel/microblaze_ksyms.c:28:
+EXPORT_SYMBOL(__ashldi3);
WARNING: externs should be avoided in .c files
#94: FILE: arch/microblaze/kernel/microblaze_ksyms.c:29:
+extern void __ashrdi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#95: FILE: arch/microblaze/kernel/microblaze_ksyms.c:30:
+EXPORT_SYMBOL(__ashrdi3);
WARNING: externs should be avoided in .c files
#96: FILE: arch/microblaze/kernel/microblaze_ksyms.c:31:
+extern void __divsi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#97: FILE: arch/microblaze/kernel/microblaze_ksyms.c:32:
+EXPORT_SYMBOL(__divsi3);
WARNING: externs should be avoided in .c files
#98: FILE: arch/microblaze/kernel/microblaze_ksyms.c:33:
+extern void __lshrdi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#99: FILE: arch/microblaze/kernel/microblaze_ksyms.c:34:
+EXPORT_SYMBOL(__lshrdi3);
WARNING: externs should be avoided in .c files
#100: FILE: arch/microblaze/kernel/microblaze_ksyms.c:35:
+extern void __modsi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#101: FILE: arch/microblaze/kernel/microblaze_ksyms.c:36:
+EXPORT_SYMBOL(__modsi3);
WARNING: externs should be avoided in .c files
#102: FILE: arch/microblaze/kernel/microblaze_ksyms.c:37:
+extern void __mulsi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#103: FILE: arch/microblaze/kernel/microblaze_ksyms.c:38:
+EXPORT_SYMBOL(__mulsi3);
WARNING: externs should be avoided in .c files
#104: FILE: arch/microblaze/kernel/microblaze_ksyms.c:39:
+extern void __muldi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#105: FILE: arch/microblaze/kernel/microblaze_ksyms.c:40:
+EXPORT_SYMBOL(__muldi3);
WARNING: externs should be avoided in .c files
#106: FILE: arch/microblaze/kernel/microblaze_ksyms.c:41:
+extern void __ucmpdi2(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#107: FILE: arch/microblaze/kernel/microblaze_ksyms.c:42:
+EXPORT_SYMBOL(__ucmpdi2);
WARNING: externs should be avoided in .c files
#108: FILE: arch/microblaze/kernel/microblaze_ksyms.c:43:
+extern void __udivsi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#109: FILE: arch/microblaze/kernel/microblaze_ksyms.c:44:
+EXPORT_SYMBOL(__udivsi3);
WARNING: externs should be avoided in .c files
#110: FILE: arch/microblaze/kernel/microblaze_ksyms.c:45:
+extern void __umodsi3(void);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#111: FILE: arch/microblaze/kernel/microblaze_ksyms.c:46:
+EXPORT_SYMBOL(__umodsi3);
total: 0 errors, 22 warnings, 231 lines checked
0011-microblaze_v8-pre-kernel-modules-support.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
False positive
-------------------------------------------------------------------------------------------
WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(),
num_possible_cpus(), for_each_possible_cpu(), etc
#367: FILE: arch/microblaze/kernel/cpu/mb.c:130:
+ return i < NR_CPUS ? (void *) (i + 1) : NULL;
total: 0 errors, 1 warnings, 438 lines checked
0013-microblaze_v8-pre-PVR-support-cpuinfo-support.patch has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
NR_CPUS is used almost in all arch (x86 use it too)
-------------------------------------------------------------------------------------------
ERROR: Don't use kernel_thread(): see Documentation/feature-removal-schedule.txt
#216: FILE: arch/microblaze/kernel/process.c:163:
+int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags)
total: 1 errors, 0 warnings, 213 lines checked
0024-microblaze_v8-pre-process-and-init-task-function.patch has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
I am not sure but I found implementation of kernel_thread in x86, powerpc has
asm implementation. Arm use C implementation as we have for MB.
-------------------------------------------------------------------------------------------
WARNING: do not add new typedefs
#112: FILE: arch/microblaze/include/asm/timex.h:14:
+typedef unsigned long cycles_t;
total: 0 errors, 1 warnings, 90 lines checked
0025-microblaze_v8-pre-delay.h-timex.h.patch has style problems, please review.
If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
WARNING: do not add new typedefs
#35: FILE: arch/microblaze/include/asm/ptrace.h:15:
+typedef unsigned long microblaze_reg_t;
total: 0 errors, 1 warnings, 250 lines checked
0026-microblaze_v8-pre-ptrace-support.patch has style problems, please review.
If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
False positive
-------------------------------------------------------------------------------------------
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#41: FILE: arch/microblaze/kernel/traps.c:23:
+void __bad_xchg(volatile void *ptr, int size)
total: 0 errors, 1 warnings, 105 lines checked
0028-microblaze_v8-pre-traps-support.patch has style problems, please review.
If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
ARM has the same implemtation - I think that's ok.
-------------------------------------------------------------------------------------------
WARNING: do not add new typedefs
#39: FILE: arch/microblaze/include/asm/mmu.h:13:
+typedef struct {
total: 0 errors, 1 warnings, 277 lines checked
0029-microblaze_v8-pre-memory-inicialization-MMU-TLB.patch has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
false positive
-------------------------------------------------------------------------------------------
WARNING: do not add new typedefs
#82: FILE: arch/microblaze/include/asm/page.h:60:
+typedef struct page *pgtable_t;
WARNING: do not add new typedefs
#83: FILE: arch/microblaze/include/asm/page.h:61:
+typedef struct { unsigned long pte; } pte_t;
WARNING: do not add new typedefs
#84: FILE: arch/microblaze/include/asm/page.h:62:
+typedef struct { unsigned long pgprot; } pgprot_t;
WARNING: do not add new typedefs
#85: FILE: arch/microblaze/include/asm/page.h:63:
+typedef struct { unsigned long ste[64]; } pmd_t;
WARNING: do not add new typedefs
#86: FILE: arch/microblaze/include/asm/page.h:64:
+typedef struct { pmd_t pue[1]; } pud_t;
WARNING: do not add new typedefs
#87: FILE: arch/microblaze/include/asm/page.h:65:
+typedef struct { pud_t pge[1]; } pgd_t;
WARNING: do not add new typedefs
#184: FILE: arch/microblaze/include/asm/segment.h:16:
+typedef struct {
total: 0 errors, 7 warnings, 205 lines checked
0030-microblaze_v8-pre-page.h-segment.h-unaligned.h.patch has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
false positive
-------------------------------------------------------------------------------------------
WARNING: do not add new typedefs
#38: FILE: arch/microblaze/include/asm/posix_types.h:18:
+typedef unsigned long __kernel_ino_t;
WARNING: do not add new typedefs
#39: FILE: arch/microblaze/include/asm/posix_types.h:19:
+typedef unsigned int __kernel_mode_t;
WARNING: do not add new typedefs
#40: FILE: arch/microblaze/include/asm/posix_types.h:20:
+typedef unsigned int __kernel_nlink_t;
WARNING: do not add new typedefs
#41: FILE: arch/microblaze/include/asm/posix_types.h:21:
+typedef long __kernel_off_t;
WARNING: do not add new typedefs
#42: FILE: arch/microblaze/include/asm/posix_types.h:22:
+typedef int __kernel_pid_t;
WARNING: do not add new typedefs
#43: FILE: arch/microblaze/include/asm/posix_types.h:23:
+typedef unsigned int __kernel_ipc_pid_t;
WARNING: do not add new typedefs
#44: FILE: arch/microblaze/include/asm/posix_types.h:24:
+typedef unsigned int __kernel_uid_t;
WARNING: do not add new typedefs
#45: FILE: arch/microblaze/include/asm/posix_types.h:25:
+typedef unsigned int __kernel_gid_t;
WARNING: do not add new typedefs
#46: FILE: arch/microblaze/include/asm/posix_types.h:26:
+typedef unsigned long __kernel_size_t;
WARNING: do not add new typedefs
#47: FILE: arch/microblaze/include/asm/posix_types.h:27:
+typedef long __kernel_ssize_t;
WARNING: do not add new typedefs
#48: FILE: arch/microblaze/include/asm/posix_types.h:28:
+typedef int __kernel_ptrdiff_t;
WARNING: do not add new typedefs
#49: FILE: arch/microblaze/include/asm/posix_types.h:29:
+typedef long __kernel_time_t;
WARNING: do not add new typedefs
#50: FILE: arch/microblaze/include/asm/posix_types.h:30:
+typedef long __kernel_suseconds_t;
WARNING: do not add new typedefs
#51: FILE: arch/microblaze/include/asm/posix_types.h:31:
+typedef long __kernel_clock_t;
WARNING: do not add new typedefs
#52: FILE: arch/microblaze/include/asm/posix_types.h:32:
+typedef int __kernel_timer_t;
WARNING: do not add new typedefs
#53: FILE: arch/microblaze/include/asm/posix_types.h:33:
+typedef int __kernel_clockid_t;
WARNING: do not add new typedefs
#54: FILE: arch/microblaze/include/asm/posix_types.h:34:
+typedef int __kernel_daddr_t;
WARNING: do not add new typedefs
#55: FILE: arch/microblaze/include/asm/posix_types.h:35:
+typedef char *__kernel_caddr_t;
WARNING: do not add new typedefs
#56: FILE: arch/microblaze/include/asm/posix_types.h:36:
+typedef unsigned short __kernel_uid16_t;
WARNING: do not add new typedefs
#57: FILE: arch/microblaze/include/asm/posix_types.h:37:
+typedef unsigned short __kernel_gid16_t;
WARNING: do not add new typedefs
#58: FILE: arch/microblaze/include/asm/posix_types.h:38:
+typedef unsigned int __kernel_uid32_t;
WARNING: do not add new typedefs
#59: FILE: arch/microblaze/include/asm/posix_types.h:39:
+typedef unsigned int __kernel_gid32_t;
WARNING: do not add new typedefs
#62: FILE: arch/microblaze/include/asm/posix_types.h:42:
+typedef long long __kernel_loff_t;
WARNING: do not add new typedefs
#65: FILE: arch/microblaze/include/asm/posix_types.h:45:
+typedef struct {
WARNING: do not add new typedefs
#119: FILE: arch/microblaze/include/asm/types.h:24:
+typedef unsigned short umode_t;
false positive
-------------------------------------------------------------------------------------------
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#37: FILE: arch/microblaze/include/asm/io.h:19:
+static inline unsigned char __raw_readb(const volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#39: FILE: arch/microblaze/include/asm/io.h:21:
+ return *(volatile unsigned char __force *)addr;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#41: FILE: arch/microblaze/include/asm/io.h:23:
+static inline unsigned short __raw_readw(const volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#43: FILE: arch/microblaze/include/asm/io.h:25:
+ return *(volatile unsigned short __force *)addr;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#45: FILE: arch/microblaze/include/asm/io.h:27:
+static inline unsigned int __raw_readl(const volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#47: FILE: arch/microblaze/include/asm/io.h:29:
+ return *(volatile unsigned int __force *)addr;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#49: FILE: arch/microblaze/include/asm/io.h:31:
+static inline unsigned long __raw_readq(const volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#51: FILE: arch/microblaze/include/asm/io.h:33:
+ return *(volatile unsigned long __force *)addr;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#53: FILE: arch/microblaze/include/asm/io.h:35:
+static inline void __raw_writeb(unsigned char v, volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#55: FILE: arch/microblaze/include/asm/io.h:37:
+ *(volatile unsigned char __force *)addr = v;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#57: FILE: arch/microblaze/include/asm/io.h:39:
+static inline void __raw_writew(unsigned short v, volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#59: FILE: arch/microblaze/include/asm/io.h:41:
+ *(volatile unsigned short __force *)addr = v;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#61: FILE: arch/microblaze/include/asm/io.h:43:
+static inline void __raw_writel(unsigned int v, volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#63: FILE: arch/microblaze/include/asm/io.h:45:
+ *(volatile unsigned int __force *)addr = v;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#65: FILE: arch/microblaze/include/asm/io.h:47:
+static inline void __raw_writeq(unsigned long v, volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#67: FILE: arch/microblaze/include/asm/io.h:49:
+ *(volatile unsigned long __force *)addr = v;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#75: FILE: arch/microblaze/include/asm/io.h:57:
+static inline unsigned char readb(const volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#77: FILE: arch/microblaze/include/asm/io.h:59:
+ return *(volatile unsigned char __force *)addr;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#79: FILE: arch/microblaze/include/asm/io.h:61:
+static inline unsigned short readw(const volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#81: FILE: arch/microblaze/include/asm/io.h:63:
+ return le16_to_cpu(*(volatile unsigned short __force *)addr);
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#83: FILE: arch/microblaze/include/asm/io.h:65:
+static inline unsigned int readl(const volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#85: FILE: arch/microblaze/include/asm/io.h:67:
+ return le32_to_cpu(*(volatile unsigned int __force *)addr);
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#87: FILE: arch/microblaze/include/asm/io.h:69:
+static inline void writeb(unsigned char v, volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#89: FILE: arch/microblaze/include/asm/io.h:71:
+ *(volatile unsigned char __force *)addr = v;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#91: FILE: arch/microblaze/include/asm/io.h:73:
+static inline void writew(unsigned short v, volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#93: FILE: arch/microblaze/include/asm/io.h:75:
+ *(volatile unsigned short __force *)addr = cpu_to_le16(v);
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#95: FILE: arch/microblaze/include/asm/io.h:77:
+static inline void writel(unsigned int v, volatile void __iomem *addr)
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#97: FILE: arch/microblaze/include/asm/io.h:79:
+ *(volatile unsigned int __force *)addr = cpu_to_le32(v);
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#146: FILE: arch/microblaze/include/asm/io.h:128:
+static inline unsigned long __iomem virt_to_phys(volatile void *address)
total: 0 errors, 29 warnings, 209 lines checked
0035-microblaze_v8-pre-io.h-IO-operations.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
false positive - same as powerpc
-------------------------------------------------------------------------------------------
WARNING: do not add new typedefs
#44: FILE: arch/microblaze/include/asm/hardirq.h:21:
+typedef struct {
total: 0 errors, 1 warnings, 153 lines checked
0038-microblaze_v8-pre-headers-for-irq.patch has style problems, please review.
If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
false positive
-------------------------------------------------------------------------------------------
ERROR: Don't use kernel_thread(): see Documentation/feature-removal-schedule.txt
#105: FILE: arch/microblaze/include/asm/processor.h:85:
+extern int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags);
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#162: FILE: arch/microblaze/include/asm/system.h:43:
+void __bad_xchg(volatile void *ptr, int size);
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#164: FILE: arch/microblaze/include/asm/system.h:45:
+static inline unsigned long __xchg(unsigned long x, volatile void *ptr,
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#173: FILE: arch/microblaze/include/asm/system.h:54:
+ ret = *(volatile unsigned char *)ptr;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#174: FILE: arch/microblaze/include/asm/system.h:55:
+ *(volatile unsigned char *)ptr = x;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#180: FILE: arch/microblaze/include/asm/system.h:61:
+ ret = *(volatile unsigned long *)ptr;
WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
#181: FILE: arch/microblaze/include/asm/system.h:62:
+ *(volatile unsigned long *)ptr = x;
total: 1 errors, 6 warnings, 184 lines checked
0041-microblaze_v8-pre-system.h-processor.h.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
kernel thread - as above. xchg -> sam as arm. Am I right?
-------------------------------------------------------------------------------------------
WARNING: do not add new typedefs
#34: FILE: arch/microblaze/include/asm/termbits.h:14:
+typedef unsigned char cc_t;
WARNING: do not add new typedefs
#35: FILE: arch/microblaze/include/asm/termbits.h:15:
+typedef unsigned int speed_t;
WARNING: do not add new typedefs
#36: FILE: arch/microblaze/include/asm/termbits.h:16:
+typedef unsigned int tcflag_t;
total: 0 errors, 3 warnings, 291 lines checked
0044-microblaze_v8-pre-termbits.h-termios.h.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
false positive
-------------------------------------------------------------------------------------------
ERROR: Aspace prohibited after that '&' (ctx:WxW)
#152: FILE: arch/microblaze/include/asm/thread_info.h:102:
+ return (struct thread_info *)(sp & ~(THREAD_SIZE-1));
^
total: 1 errors, 0 warnings, 176 lines checked
0053-microblaze_v8-pre-string.h-thread_info.h.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
I think here is correct coding style.
-------------------------------------------------------------------------------------------
That's all.
M
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
next prev parent reply other threads:[~2009-03-19 9:43 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 20:30 Microblaze linux support monstr
2009-03-18 20:30 ` [PATCH 01/57] microblaze_v7: Kconfig patches monstr
2009-03-18 20:30 ` [PATCH 02/57] microblaze_v7: Makefiles for Microblaze cpu monstr
2009-03-18 20:30 ` [PATCH 03/57] microblaze_v7: Cpuinfo handling monstr
2009-03-18 20:30 ` [PATCH 04/57] microblaze_v7: Open firmware files monstr
2009-03-23 18:51 ` Arnd Bergmann
2009-03-23 18:51 ` Arnd Bergmann
2009-03-23 20:44 ` Michal Simek
2009-03-23 20:53 ` Anton Vorontsov
2009-03-23 20:53 ` Anton Vorontsov
2009-03-26 0:01 ` Benjamin Herrenschmidt
2009-03-26 0:01 ` Benjamin Herrenschmidt
2009-03-24 11:17 ` Michal Simek
2009-03-24 11:17 ` Michal Simek
2009-03-18 20:30 ` [PATCH 05/57] microblaze_v7: Platorm bus registration monstr
2009-03-18 20:30 ` [PATCH 06/57] microblaze_v7: exception handling monstr
2009-03-18 20:30 ` [PATCH 07/57] microblaze_v7: Signal support monstr
2009-03-23 19:35 ` Arnd Bergmann
2009-03-24 11:14 ` Michal Simek
2009-03-18 20:30 ` [PATCH 08/57] microblaze_v7: Interrupt handling, timer support, selfmod code monstr
2009-03-19 15:49 ` Thomas Gleixner
2009-03-19 20:28 ` Michal Simek
2009-03-19 21:47 ` Thomas Gleixner
2009-03-20 2:24 ` John Stultz
2009-03-20 7:27 ` Michal Simek
2009-03-20 20:40 ` john stultz
2009-03-21 10:38 ` Michal Simek
2009-03-21 11:14 ` Thomas Gleixner
2009-03-21 11:57 ` Michal Simek
2009-03-21 12:05 ` Thomas Gleixner
2009-03-21 12:07 ` Michal Simek
2009-03-20 6:38 ` Michal Simek
2009-03-20 10:07 ` Thomas Gleixner
2009-03-20 9:26 ` Michal Simek
2009-03-20 9:58 ` Thomas Gleixner
2009-03-20 10:37 ` Michal Simek
2009-03-20 10:49 ` Thomas Gleixner
2009-03-20 11:28 ` Michal Simek
2009-03-20 11:41 ` Thomas Gleixner
2009-03-20 11:59 ` Michal Simek
2009-03-20 14:08 ` Michal Simek
2009-03-20 14:12 ` Thomas Gleixner
2009-03-20 14:27 ` Michal Simek
2009-03-18 20:30 ` [PATCH 09/57] microblaze_v7: cache support monstr
2009-03-18 20:30 ` [PATCH 10/57] microblaze_v7: Generic dts file for platforms monstr
2009-03-18 20:30 ` [PATCH 11/57] microblaze_v7: kernel modules support monstr
2009-03-18 20:30 ` [PATCH 12/57] microblaze_v7: lmb include file monstr
2009-03-18 20:30 ` [PATCH 13/57] microblaze_v7: PVR support, cpuinfo support monstr
2009-03-18 20:30 ` [PATCH 14/57] microblaze_v7: defconfig file monstr
2009-03-18 20:30 ` [PATCH 15/57] microblaze_v7: assembler files head.S, entry-nommu.S, syscall_table.S monstr
2009-03-18 20:30 ` [PATCH 16/57] microblaze_v7: vmlinux.lds.S - linker script monstr
2009-03-18 20:30 ` [PATCH 17/57] microblaze_v7: supported function for memory - kernel/lib monstr
2009-03-18 20:30 ` [PATCH 18/57] microblaze_v7: checksum support monstr
2009-03-18 20:30 ` [PATCH 19/57] microblaze_v7: early_printk support monstr
2009-03-18 20:30 ` [PATCH 20/57] microblaze_v7: uaccess files monstr
2009-03-18 20:30 ` [PATCH 21/57] microblaze_v7: heartbeat file monstr
2009-03-18 20:30 ` [PATCH 22/57] microblaze_v7: setup.c, setup.h - system setting monstr
2009-03-18 20:30 ` [PATCH 23/57] microblaze_v7: asm-offsets monstr
2009-03-18 20:30 ` [PATCH 24/57] microblaze_v7: process and init task function monstr
2009-03-18 20:30 ` [PATCH 25/57] microblaze_v7: delay.h, timex.h monstr
2009-03-18 20:30 ` [PATCH 26/57] microblaze_v7: ptrace support monstr
2009-03-18 20:30 ` [PATCH 27/57] microblaze_v7: IPC support monstr
2009-03-18 20:30 ` [PATCH 28/57] microblaze_v7: traps support monstr
2009-03-18 20:30 ` [PATCH 29/57] microblaze_v7: memory inicialization, MMU, TLB monstr
2009-03-18 20:30 ` [PATCH 30/57] microblaze_v7: page.h, segment.h, unaligned.h monstr
2009-03-18 20:30 ` [PATCH 31/57] microblaze_v7: includes SHM*, msgbuf monstr
2009-03-18 20:30 ` [PATCH 32/57] microblaze_v7: bug headers files monstr
2009-03-18 20:31 ` [PATCH 33/57] microblaze_v7: definitions of types monstr
2009-03-18 20:31 ` [PATCH 34/57] microblaze_v7: ioctl support monstr
2009-03-18 20:31 ` [PATCH 35/57] microblaze_v7: io.h IO operations monstr
2009-03-18 20:31 ` [PATCH 36/57] microblaze_v7: headers for executables format FLAT, ELF monstr
2009-03-18 20:31 ` [PATCH 37/57] microblaze_v7: dma support monstr
2009-03-18 20:31 ` [PATCH 38/57] microblaze_v7: headers for irq monstr
2009-03-18 20:31 ` [PATCH 39/57] microblaze_v7: atomic.h bitops.h swab.h byteorder.h monstr
2009-03-18 20:31 ` [PATCH 40/57] microblaze_v7: headers pgalloc.h pgtable.h monstr
2009-03-18 20:31 ` [PATCH 41/57] microblaze_v7: system.h processor.h monstr
2009-03-18 20:31 ` [PATCH 42/57] microblaze_v7: clinkage.h linkage.h sections.h kmap_types.h monstr
2009-03-18 20:31 ` [PATCH 43/57] microblaze_v7: stats headers monstr
2009-03-18 20:31 ` [PATCH 44/57] microblaze_v7: termbits.h termios.h monstr
2009-03-23 19:37 ` Arnd Bergmann
2009-03-24 11:20 ` Michal Simek
2009-03-24 13:57 ` Arnd Bergmann
2009-03-24 14:06 ` John Williams
2009-03-24 14:44 ` Michal Simek
2009-03-18 20:31 ` [PATCH 45/57] microblaze_v7: sigcontext.h siginfo.h monstr
2009-03-18 20:31 ` [PATCH 46/57] microblaze_v7: headers simple files - empty or redirect to asm-generic monstr
2009-03-18 20:31 ` [PATCH 47/57] microblaze_v7: namei.h monstr
2009-03-18 20:31 ` [PATCH 48/57] microblaze_v7: headers files entry.h current.h mman.h registers.h sembuf.h monstr
2009-03-18 20:31 ` [PATCH 49/57] microblaze_v7: device.h param.h topology.h monstr
2009-03-18 20:31 ` [PATCH 50/57] microblaze_v7: pool.h socket.h monstr
2009-03-18 20:31 ` [PATCH 51/57] microblaze_v7: fcntl.h sockios.h ucontext.h monstr
2009-03-18 20:31 ` [PATCH 52/57] microblaze_v7: unistd.h monstr
2009-03-18 20:31 ` [PATCH 53/57] microblaze_v7: string.h thread_info.h monstr
2009-03-18 20:31 ` [PATCH 54/57] microblaze_v7: Kbuild file monstr
2009-03-18 20:31 ` [PATCH 55/57] microblaze_v7: pci headers monstr
2009-03-18 20:31 ` [PATCH 56/57] microblaze_v7: syscalls.h monstr
2009-03-18 20:31 ` [PATCH 57/57] microblaze_v7: Uartlite for Microblaze monstr
2009-03-24 16:03 ` Michal Simek
2009-03-24 16:03 ` Michal Simek
2009-03-24 16:22 ` John Williams
2009-03-24 16:22 ` John Williams
2009-03-24 16:47 ` Peter Korsgaard
2009-03-25 15:42 ` [PATCH 01/57] microblaze_v7: Kconfig patches Arnd Bergmann
2009-03-25 16:10 ` Michal Simek
2009-03-19 7:22 ` Microblaze linux support Ingo Molnar
2009-03-19 9:42 ` Michal Simek [this message]
2009-03-19 10:21 ` Ingo Molnar
2009-03-19 10:26 ` Michal Simek
2009-03-19 10:47 ` Jaswinder Singh Rajput
2009-03-19 11:10 ` Michal Simek
2009-03-19 10:50 ` Ingo Molnar
2009-03-19 10:52 ` Michal Simek
2009-03-19 11:00 ` Ingo Molnar
2009-03-19 11:04 ` Michal Simek
2009-03-19 20:35 ` Randy Dunlap
2009-03-19 20:41 ` Michal Simek
2009-03-24 15:26 ` Michal Simek
2009-03-24 15:33 ` John Linn
2009-03-24 15:42 ` Michal Simek
2009-03-24 17:46 ` [microblaze-uclinux] " Stephen Neuendorffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C213A2.4040609@monstr.eu \
--to=monstr@monstr.eu \
--cc=akpm@linux-foundation.org \
--cc=john.williams@petalogix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.