All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Tejun Heo <tj@kernel.org>,
	open-osd mailing-list <osd-dev@open-osd.org>
Subject: Re: [PATCHSET  0/2] Don't let blk_put_request leak BIOs
Date: Thu, 19 Mar 2009 16:50:47 +0200	[thread overview]
Message-ID: <49C25BC7.1020900@panasas.com> (raw)
In-Reply-To: <20090319142419.GS27476@kernel.dk>

Jens Axboe wrote:
>> So current (above) code in osd_initiator.c is correct and should stay
>> as it is? that's fine by me.
> 
> It's still not pretty, any reason you can't just use blk_end_request()?
> Why do you need to unroll the bios manually?
> 

I have stared at blk_end_request() multiple times, and I'm afraid to call it
it does to many things. accounting, end_that_request_last, lots of not needed
stuff. This is a request that was never on any submission Q, it is scary.
Also I'm not sure what is the request state it can be very partially built
at this stage.

But mainly I do not want that bio->bi_end_io(bio, error); will be called.
I don't want any read bouncing to happen, just return them to free store.

I will try the blk_end_request(,-EIO) and see if it works for all cases

Thanks
Boaz

  reply	other threads:[~2009-03-19 14:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19 10:20 [PATCHSET 0/2] Don't let blk_put_request leak BIOs Boaz Harrosh
2009-03-19 10:24 ` [PATCH 1/2] TESTING: " Boaz Harrosh
2009-03-19 10:26 ` [PATCH 2/2] libosd: Don't let osd abuse block internals, now that it's fixed Boaz Harrosh
2009-03-19 11:33 ` [PATCHSET 0/2] Don't let blk_put_request leak BIOs Jens Axboe
2009-03-19 13:40   ` Boaz Harrosh
2009-03-19 13:45     ` Jens Axboe
2009-03-19 13:48       ` Boaz Harrosh
2009-03-19 13:56         ` Jens Axboe
2009-03-19 14:18           ` Boaz Harrosh
2009-03-19 14:24             ` Jens Axboe
2009-03-19 14:50               ` Boaz Harrosh [this message]
2009-03-19 16:29   ` [PATCH] WARN_ON if blk_put_request leaks BIOs Boaz Harrosh
2009-03-20 20:45     ` Jens Axboe
2009-03-22  8:51       ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C25BC7.1020900@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=osd-dev@open-osd.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.