From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LkJgD-0004Wg-S6
	for qemu-devel@nongnu.org; Thu, 19 Mar 2009 10:57:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LkJg8-0004Vq-3G
	for qemu-devel@nongnu.org; Thu, 19 Mar 2009 10:57:08 -0400
Received: from [199.232.76.173] (port=40333 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LkJg7-0004Vn-Sn
	for qemu-devel@nongnu.org; Thu, 19 Mar 2009 10:57:03 -0400
Received: from citadel.icyb.net.ua ([212.40.38.140]:1069)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avg@icyb.net.ua>) id 1LkJg7-0004ll-7w
	for qemu-devel@nongnu.org; Thu, 19 Mar 2009 10:57:03 -0400
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA06865
	for <qemu-devel@nongnu.org>; Thu, 19 Mar 2009 16:56:56 +0200 (EET)
	(envelope-from avg@icyb.net.ua)
Message-ID: <49C25D37.90302@icyb.net.ua>
Date: Thu, 19 Mar 2009 16:56:55 +0200
From: Andriy Gapon <avg@icyb.net.ua>
MIME-Version: 1.0
References: <49BFC8B0.2060609@icyb.net.ua>
	<49BFC930.9040609@icyb.net.ua>	<49C0F7D9.8040504@icyb.net.ua>
	<201500.89408.qm@web24507.mail.ird.yahoo.com>
In-Reply-To: <201500.89408.qm@web24507.mail.ird.yahoo.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Re : Re: patch: (attempt to) emulate 440BX/PIIX4
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

on 18/03/2009 18:12 Sylvain Petreolle said the following:
> 
> This part should should change piix3_devfn to piix4_devfn IMHO.
> 
> --- hw/pc.c.orig    2009-03-04 22:54:45.000000000 +0000
> +++ hw/pc.c    2009-03-17 07:47:58.120091474 +0000
> @@ -938,7 +941,7 @@
> 
>     if (pci_enabled) {
>         pci_bus = i440fx_init(&i440fx_state, i8259);
> -        piix3_devfn = piix3_init(pci_bus, -1);
> +        piix3_devfn = piix4_init(pci_bus, 7 << 3);
>  Kind regards,

Yes, this would be correct from code self-descriptiveness point of view and it
must be done. I just wanted to initially produce a minimalistic obvious patch, so
that people could review and comment.

-- 
Andriy Gapon