From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] fs-backend: fix gnttab unmap
Date: Thu, 19 Mar 2009 16:58:50 +0000 [thread overview]
Message-ID: <49C279CA.1000004@eu.citrix.com> (raw)
Hi all,
when a stubdom is destroyed, fs-backend does not correctly unmap all the
pages mapped for the shared ring.
This causes some pages not to be properly freed by xen, hence after a
cycle of 50 save\restore we don't have enough spare memory to start 2
VMs any more.
This patch fixes the issue properly unmapping all the pages needed by
the shared ring.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
diff -r 633e08774dab tools/fs-back/fs-backend.c
--- a/tools/fs-back/fs-backend.c Thu Mar 19 14:01:56 2009 +0000
+++ b/tools/fs-back/fs-backend.c Thu Mar 19 16:33:34 2009 +0000
@@ -161,7 +161,7 @@
while (!xenbus_frontend_state_changed(mount, STATE_CLOSING));
xenbus_write_backend_state(mount, STATE_CLOSED);
- xc_gnttab_munmap(mount->gnth, mount->ring.sring, 1);
+ xc_gnttab_munmap(mount->gnth, mount->ring.sring, mount->shared_ring_size);
xc_gnttab_close(mount->gnth);
xc_evtchn_unbind(mount->evth, mount->local_evtchn);
xc_evtchn_close(mount->evth);
next reply other threads:[~2009-03-19 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 16:58 Stefano Stabellini [this message]
2009-03-20 22:00 ` [PATCH] fs-backend: fix gnttab unmap Keith Coleman
2009-03-23 10:48 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C279CA.1000004@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.