From: Masami Hiramatsu <mhiramat@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Ingo Molnar <mingo@elte.hu>
Cc: systemtap-ml <systemtap@sources.redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [RFC][PATCH -tip 9/9] tracing: kprobe-tracer plugin supports module_probe
Date: Thu, 19 Mar 2009 17:10:49 -0400 [thread overview]
Message-ID: <49C2B4D9.6040602@redhat.com> (raw)
Use register/unregister_module_*probe functions for tracing
module .init/.exit functions.
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
---
kernel/trace/trace_kprobe.c | 15 ++++++++++-----
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index e801e8c..7b7ab53 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -226,6 +226,11 @@ static void free_trace_probe(struct trace_probe *tp)
kfree(tp);
}
+static int activate_handler(void *offset, struct module *mod)
+{
+ return ((unsigned long)offset == 0) ? 1 : 0;
+}
+
static int register_trace_probe(struct trace_probe *tp)
{
int ret;
@@ -234,9 +239,10 @@ static int register_trace_probe(struct trace_probe *tp)
list_add_tail(&tp->list, &probe_list);
if (probe_is_return(tp))
- ret = register_kretprobe(&tp->rp);
+ ret = register_module_kretprobe(&tp->rp, activate_handler, 0);
else
- ret = register_kprobe(&tp->kp);
+ ret = register_module_kprobe(&tp->kp, activate_handler,
+ (void *)(tp->kp.offset));
if (ret) {
pr_warning("Probe registering error: %d\n", ret);
@@ -249,9 +255,9 @@ static int register_trace_probe(struct trace_probe *tp)
static void unregister_trace_probe(struct trace_probe *tp)
{
if (probe_is_return(tp))
- unregister_kretprobe(&tp->rp);
+ unregister_module_kretprobe(&tp->rp);
else
- unregister_kprobe(&tp->kp);
+ unregister_module_kprobe(&tp->kp);
list_del(&tp->list);
}
@@ -301,7 +307,6 @@ static int create_trace_probe(int argc, char **argv)
} else {
/* a symbol specified */
symbol = argv[1];
- /* TODO: support .init module functions */
tmp = strchr(symbol, '+');
if (!tmp)
tmp = strchr(symbol, '-');
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next reply other threads:[~2009-03-19 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 21:10 Masami Hiramatsu [this message]
2009-03-20 0:08 ` [RFC][PATCH -tip 9/9] tracing: kprobe-tracer plugin supports module_probe Steven Rostedt
2009-03-20 3:57 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C2B4D9.6040602@redhat.com \
--to=mhiramat@redhat.com \
--cc=ananth@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.