All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yang, Xiaowei" <xiaowei.yang@intel.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Fix domheap structure allocation when	 NUMA=on
Date: Fri, 20 Mar 2009 16:34:31 +0800	[thread overview]
Message-ID: <49C35517.7040706@intel.com> (raw)
In-Reply-To: <49C35EA9.76E4.0078.0@novell.com>

Jan Beulich wrote:
>>>> "Yang, Xiaowei" <xiaowei.yang@intel.com> 20.03.09 06:05 >>>
>> DIRECTMAP_VIRT_END can't be passed to virt_to_mfn(), as it's just beyond 
>> direct map boundary and triggers ASSERT very early at boot time.
> 
> While I agree to the analysis, I would think that this
> 
> +              mfn + needed <= virt_to_mfn(DIRECTMAP_VIRT_END - PAGE_SIZE) )
> 
> should rather be
> 
> +              mfn + needed <= virt_to_mfn(DIRECTMAP_VIRT_END - 1) + 1 )
> 
virt_to_mfn(DIRECTMAP_VIRT_END - 1) is equal to 
virt_to_mfn(DIRECTMAP_VIRT_END - PAGE_SIZE). Why +1? We use '<=' here.

Thanks,
xiaowei

  reply	other threads:[~2009-03-20  8:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20  5:05 [PATCH] Fix domheap structure allocation when NUMA=on Yang, Xiaowei
2009-03-20  8:15 ` Jan Beulich
2009-03-20  8:34   ` Yang, Xiaowei [this message]
2009-03-20  8:47     ` Jan Beulich
2009-03-20  8:56       ` Keir Fraser
2009-03-20  9:27         ` Jan Beulich
2009-03-20  9:32           ` Keir Fraser
2009-03-24 10:48       ` Yang, Xiaowei
2009-03-24 10:55         ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C35517.7040706@intel.com \
    --to=xiaowei.yang@intel.com \
    --cc=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.