From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LkaEq-000159-Oo
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 04:38:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LkaEj-00013M-4U
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 04:37:57 -0400
Received: from [199.232.76.173] (port=53421 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LkaEi-00013I-RW
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 04:37:52 -0400
Received: from mx2.redhat.com ([66.187.237.31]:37071)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1LkaEi-00048I-AV
	for qemu-devel@nongnu.org; Fri, 20 Mar 2009 04:37:52 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2K8bnmH018485
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 04:37:51 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2K8bkPf012199
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 04:37:46 -0400
Received: from zweiblum.home.kraxel.org (vpn-10-79.str.redhat.com
	[10.32.10.79])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2K8bltJ025839
	for <qemu-devel@nongnu.org>; Fri, 20 Mar 2009 04:37:48 -0400
Message-ID: <49C355DA.8070504@redhat.com>
Date: Fri, 20 Mar 2009 09:37:46 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates.
References: <49C11CAC.3060405@redhat.com> <49C28020.5060503@eu.citrix.com>
In-Reply-To: <49C28020.5060503@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefano Stabellini wrote:
> I like the idea behind this patch, but I would make force_update an
> unsigned integer instead of a boolean, incrementing it every time we get a
> framebuffer_update_request and decrementing it every time we send a
> reply.

Point being?
Note that we can satisfy multiple update requests in one reply.
Also note that vnc_copy() sets force_update too.

> Secondly we could even move vga_hw_update after:
> 
> if (vs->output.offset && !vs->audio_cap && !vs->force_update)

Agreed.

cheers,
  Gerd