All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Coldire: mcf52x2: Improve gcc version detection
Date: Fri, 20 Mar 2009 09:27:06 -0400	[thread overview]
Message-ID: <49C399AA.2030107@RuggedCom.com> (raw)
In-Reply-To: <20090319211415.355BB832E8B7@gemini.denx.de>

Hi Wolfgang,

> What makes you think that
> 
> 	echo __GNUC__ __GNUC_MINOR__ | $(CC) -E -xc - \
> 	| tail -n 1 | sed -e 's/ /0/'
> 
> would be any better than parsing the output of "$(CC) --version"? 
> 
> The fact that it takes 4 processes instead of one (or say two if we
> add the filtering) is not a recommendation.
>

Thanks for the comments,

sorry if I'm (re)stating the obvious, but just to be clear:

ifneq ($(findstring 4.1,$(shell $(CC) --version)),4.1)

while simple, will cause gcc-4.0.x or gcc-3.x.x to try to use the -mcpu option
which is not supported yet until gcc-4.2.+ (if I am not mistaken).

I realize the world is always moving forward and this is an increasingly moot argument,
but the embedded world is often very attached to our toolchains :P

I am sure there are many better ways of extracting the version string, my attempt is to
highlight one way that converts the version to a number and use the '-gt' to compare on it.

Feel free to educate me in 'the better way', my user-space kung-fu is not that strong yet :)

Regards,

- Richard Retanubun

  reply	other threads:[~2009-03-20 13:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19 14:32 [U-Boot] [PATCH] Coldire: mcf52x2: Improve gcc version detection Richard Retanubun
2009-03-19 21:14 ` Wolfgang Denk
2009-03-20 13:27   ` Richard Retanubun [this message]
2009-03-20 13:44     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C399AA.2030107@RuggedCom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.