From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LlA2e-00029g-Mx for mharc-grub-devel@gnu.org; Sat, 21 Mar 2009 18:51:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LlA2b-00029B-NZ for grub-devel@gnu.org; Sat, 21 Mar 2009 18:51:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LlA2W-00028q-9o for grub-devel@gnu.org; Sat, 21 Mar 2009 18:51:44 -0400 Received: from [199.232.76.173] (port=53287 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LlA2W-00028n-4F for grub-devel@gnu.org; Sat, 21 Mar 2009 18:51:40 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:4386) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LlA2V-0003Qm-Ji for grub-devel@gnu.org; Sat, 21 Mar 2009 18:51:39 -0400 Received: by fg-out-1718.google.com with SMTP id 19so423848fgg.7 for ; Sat, 21 Mar 2009 15:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=OrdAap9/XI/6E/HvZGUaUHZ3eKqZ6Az5qqwllBaXENU=; b=QGcpCXNoIokt4rCZezw44m1Gj0LR2mWMvl86TGCr595K4s4kllR7GRXt6WRes+qqNM sV77QhkjueTF0hf36CPB54HPjnOAzl1dhKwVldt9zigAIYCP9MP0GuLKU69egGTzkshV n7jyO5oaHxdf6tBPp6XYMFtusrifBwYjJbkXs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=PLYDKLaOdRc3MIpQQ+rgwQ5wu27GEKNqOe6qB6GrmGrIBabN11msNnWcxt6SM7ETPB HVmBesBrfDDD3GsZcBA4dVVsLq9Y9hdHSFYGH92l3h5cLem4uMdvmgD5+xOobtmS9OGg v4VnLf3o/eCG7ERcBzutknRfa7oIurOG6ALFs= Received: by 10.86.76.16 with SMTP id y16mr2488914fga.18.1237675895976; Sat, 21 Mar 2009 15:51:35 -0700 (PDT) Received: from ?192.168.1.25? (217-154.203-62.cust.bluewin.ch [62.203.154.217]) by mx.google.com with ESMTPS id 12sm1154687fgg.7.2009.03.21.15.51.35 (version=SSLv3 cipher=RC4-MD5); Sat, 21 Mar 2009 15:51:35 -0700 (PDT) Message-ID: <49C56F76.8010400@gmail.com> Date: Sat, 21 Mar 2009 23:51:34 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <4992ABA6.7040200@gmail.com> <49BAEDAD.3030704@gmail.com> <20090314144844.GA13451@thorin> <49BBEEF7.9000107@gmail.com> <20090315153455.GA24554@thorin> In-Reply-To: <20090315153455.GA24554@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [Patch] Move multiboot helpers out of the kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2009 22:51:45 -0000 Robert Millan wrote: > On Sat, Mar 14, 2009 at 06:52:55PM +0100, phcoder wrote: >> Robert Millan wrote: >>> On Sat, Mar 14, 2009 at 12:35:09AM +0100, phcoder wrote: >>>> Index: conf/i386-ieee1275.rmk >>>> =================================================================== >>>> --- conf/i386-ieee1275.rmk (revision 2030) >>>> +++ conf/i386-ieee1275.rmk (working copy) >>>> @@ -126,10 +126,12 @@ >>>> # For _multiboot.mod. >>>> _multiboot_mod_SOURCES = loader/ieee1275/multiboot2.c \ >>>> + loader/i386/multiboot_helper.S \ >>> multiboot_helper.S is not being used on i386-ieee1275 AFAICT >> How can it be if multiboot.c is the same for pc and ieee1275? > > $ grep multiboot.c conf/*.rmk > conf/i386-coreboot.rmk:_multiboot_mod_SOURCES = loader/i386/multiboot.c \ > conf/i386-pc.rmk:_multiboot_mod_SOURCES = loader/i386/multiboot.c \ > void grub_mb2_arch_boot (grub_addr_t entry_addr, void *tags) { #if defined(__powerpc__) kernel_entry_t entry = (kernel_entry_t) entry_addr; entry (MULTIBOOT2_BOOTLOADER_MAGIC, tags, grub_ieee1275_entry_fn, 0, 0); #elif defined(__i386__) grub_multiboot2_real_boot (entry_addr, tags); #else #error #endif } As you see it uses grub_multiboot2_real_boot >>> grub_dl_unload_all() just disappeared. Is this intentional? I >>> tend to agree that grub_dl_unload_all() is a waste of time, but >>> this should be discussed separately. >> It is intentional because multiboot_real_boot is now in a module so we >> can't unload it > > Ok then, I'm fine with disabling the unload. What does everybody else > think? > -- Regards Vladimir 'phcoder' Serbinenko