Re: [PATCH 1/2] ide: turn selectproc() method into dev_select() method

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Bartlomiej Zolnierkiewicz wrote:

>>Hello, I wrote:

>>>Turn selectproc() method into dev_select() method by teaching it to write to the
>>>device register and moving it from 'struct ide_port_ops' to 'struct ide_tp_ops'.

>>>Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

>>[...]

>>>Index: linux-2.6/drivers/ide/trm290.c
>>>===================================================================
>>>--- linux-2.6.orig/drivers/ide/trm290.c
>>>+++ linux-2.6/drivers/ide/trm290.c
>>>@@ -171,10 +171,11 @@ static void trm290_prepare_drive (ide_dr
>>> 	local_irq_restore(flags);
>>> }
>>> 
>>>-static void trm290_selectproc (ide_drive_t *drive)
>>>+static void trm290_dev_select(ide_drive_t *drive)
>>> {
>>> 	trm290_prepare_drive(drive, !!(drive->dev_flags & IDE_DFLAG_USING_DMA));
>>>-}
>>>+
>>>+	outb(drive->select | ATA_DEVICE_OBS, drive->hwif->io_ports.device_addr);}

>>    Oops, I keep forgetting about running checkpatch.pl first. :-<
>>    Bart, do I need to repost, or you can fix it while applying?

> fixed while applying

> ditto for:

> drivers/ide/ns87415.c:314: error: ‘ns87415_tp_ops’ undeclared here (not in a function)
> make[1]: *** [drivers/ide/ns87415.o] Error 1
> make: *** [drivers/ide/ns87415.o] Error 2

    Since the patch has turned to ve fatally defective in yet another way, 
I'll have to recast/resend it anyway...

MBR, Sergei