From: Tim Blechmann <tim@klingt.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: alsa driver for digigram lx6464es
Date: Mon, 23 Mar 2009 12:04:43 +0100 [thread overview]
Message-ID: <49C76CCB.6000003@klingt.org> (raw)
In-Reply-To: <s5htz5k5xas.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 931 bytes --]
>> please note, that i included 4 header files and some minor code portions
>> from digigram's windows driver, which do not match the linux coding
>> style. i preferred to do so in order to keep the similarity to the
>> windows driver, which was my main reference for implementing the driver.
>
> Well, basically it doesn't help to keep the non-standard coding style.
> Once after your code is merged to the kernel tree, it's no more your
> baby. Everyone will modify the code, and one of people's favorite
> actions is to re-format codes to improve the readability :)
ok, i'll write a new header file for the specific definitions ... that's
probably better than messing with Lindent or similar to reformat the
digigram sources ...
and thanks for the other comments ... i'll adapt the code ...
cheers, tim
--
tim@klingt.org
http://tim.klingt.org
I don't write music for sissy ears.
Charles Ives
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2009-03-23 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 19:34 alsa driver for digigram lx6464es Tim Blechmann
2009-03-23 6:53 ` Takashi Iwai
2009-03-23 10:12 ` [PATCH] alsa: lx6464es - driver for the digigram lx6464es interface Tim Blechmann
2009-03-23 10:44 ` Takashi Iwai
2009-03-24 11:23 ` Tim Blechmann
2009-03-24 11:24 ` [PATCH v2] " Tim Blechmann
2009-03-25 11:11 ` Takashi Iwai
2009-03-25 13:56 ` Tim Blechmann
2009-04-14 12:18 ` Takashi Iwai
2009-03-23 10:26 ` alsa driver for digigram lx6464es Tim Blechmann
2009-03-23 10:49 ` Takashi Iwai
2009-03-23 11:04 ` Tim Blechmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C76CCB.6000003@klingt.org \
--to=tim@klingt.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.