From: Gerd Hoffmann <kraxel@redhat.com>
To: Simon Horman <horms@verge.net.au>
Cc: xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 3/5] Fixup dummy cpu setup.
Date: Mon, 23 Mar 2009 12:25:15 +0100 [thread overview]
Message-ID: <49C7719B.7080503@redhat.com> (raw)
In-Reply-To: <20090320224154.GA2799@verge.net.au>
Simon Horman wrote:
>> - env = cpu_init(NULL);
>> + if (cpu_model == NULL) {
>> +#ifdef TARGET_X86_64
>> + cpu_model = "qemu64";
>> +#else
>> + cpu_model = "qemu32";
>> +#endif
>> + }
>> + env = cpu_init(cpu_model);
> Is there a way to achieve this without ifdef nastiness?
Well, one could try to make cpu_init(NULL) pick a sane default. But in
the end that most likely would just be moving the ifdef to another place.
cheers,
Gerd
next prev parent reply other threads:[~2009-03-23 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 16:02 [PATCH 0/5] some small cleanups for xen_machine_pv.c Gerd Hoffmann
2009-03-20 16:02 ` [PATCH 1/5] xen_machine_pv.c: switch to C99 initializers Gerd Hoffmann
2009-03-20 16:02 ` [PATCH 2/5] xen_machine_pv.c: delete pointless coomment Gerd Hoffmann
2009-03-20 16:02 ` [PATCH 3/5] Fixup dummy cpu setup Gerd Hoffmann
2009-03-20 22:41 ` Simon Horman
2009-03-23 11:25 ` Gerd Hoffmann [this message]
2009-03-23 21:39 ` Simon Horman
2009-03-20 16:02 ` [PATCH 4/5] use uint32_t for xen_domid Gerd Hoffmann
2009-03-20 16:59 ` Dan Magenheimer
2009-03-23 11:20 ` Gerd Hoffmann
2009-03-20 16:02 ` [PATCH 5/5] kill unused variables Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C7719B.7080503@redhat.com \
--to=kraxel@redhat.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=horms@verge.net.au \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.