All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [Patch] Move normal.mod to conf/common.rmk
Date: Mon, 23 Mar 2009 18:15:14 +0200	[thread overview]
Message-ID: <49C7B592.9090307@nic.fi> (raw)
In-Reply-To: <49C7A64F.30004@gmail.com>

phcoder wrote:
> Hello. I propose to create a symlink normal/cpu. This way normal.mod can
> be moved to conf/common.rmk. Works fine on i386-pc. Can people having
> other platforms test?

I do not like the fact that you hardcoded filenames what can be on
platform dependant parts.

I have also though this issue some times and I think the best option
would be:

## common.rmk ##

normal.mod: <common files> normal_arch.lib

## arch.rmk ##

normal_arch.lib: setjmp.S <or what ever is needed for the platform.>




  reply	other threads:[~2009-03-23 16:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23 15:10 [Patch] Move normal.mod to conf/common.rmk phcoder
2009-03-23 16:15 ` Vesa Jääskeläinen [this message]
2009-03-23 16:36   ` phcoder
2009-03-23 18:40     ` Vesa Jääskeläinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C7B592.9090307@nic.fi \
    --to=chaac@nic.fi \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.