From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lln8Y-000180-Hm for mharc-grub-devel@gnu.org; Mon, 23 Mar 2009 12:36:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lln8W-00013B-9L for grub-devel@gnu.org; Mon, 23 Mar 2009 12:36:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lln8R-0000su-F2 for grub-devel@gnu.org; Mon, 23 Mar 2009 12:36:27 -0400 Received: from [199.232.76.173] (port=41777 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lln8Q-0000sP-W0 for grub-devel@gnu.org; Mon, 23 Mar 2009 12:36:23 -0400 Received: from mail-fx0-f166.google.com ([209.85.220.166]:38117) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lln8Q-0007de-ML for grub-devel@gnu.org; Mon, 23 Mar 2009 12:36:22 -0400 Received: by fxm10 with SMTP id 10so1741352fxm.42 for ; Mon, 23 Mar 2009 09:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=PhNKQAUwXcFGQf4IwYyxHayxsSBFUq2IbBLtooBGSLs=; b=iSUYWsPOeiYVOnRELYx2eI58vQrVu/XxTJHAKa6PLW5NpqSVa8hLI3jCGHrzK8JQla A9rJxSfr+4++W/8jwYu0Ceu3RxpUzVUSUIz3EWOdGMxB5lar9cerDJGeYofsF3By9PmO H6SwwQ7/MnzxiM+eYL9KuGboT7hpW5NeHeSUw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=xAH212cWdI0Cc5jaQNAFHmWEwisTajB2zChZgM3L+MteRo+RhXP+hU2tdhUxTBt0+N WDQ0Nf5Ue6H0rUF3oifOZz15hS85q9YCUstPwAu3mTO9lCd+cyyIK4ezHTdtTQqGo7FY l9VLiW49szWPXc0OEIRQ6FOSIwFStJXFVSblA= Received: by 10.86.94.11 with SMTP id r11mr3828290fgb.53.1237826181784; Mon, 23 Mar 2009 09:36:21 -0700 (PDT) Received: from ?192.168.1.2? (173-122.3-85.cust.bluewin.ch [85.3.122.173]) by mx.google.com with ESMTPS id 3sm1327965fge.29.2009.03.23.09.36.21 (version=SSLv3 cipher=RC4-MD5); Mon, 23 Mar 2009 09:36:21 -0700 (PDT) Message-ID: <49C7BA85.30604@gmail.com> Date: Mon, 23 Mar 2009 17:36:21 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49C7A64F.30004@gmail.com> <49C7B592.9090307@nic.fi> In-Reply-To: <49C7B592.9090307@nic.fi> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [Patch] Move normal.mod to conf/common.rmk X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2009 16:36:28 -0000 Actually if it was up to me I would have removed setjmp altogether. IMHO it's a bad programming technique. It's used only to launch rescue mode. I would just call the rescue mode interpreter by function. Perhaps Bean who is working on normal.mod splitting has even better idea. Also IMO normal.mod should have no arch-dependent parts and setjmp.S is an unfortunate example. If some platforms need a special service then it could be provided by drivers and/or commands. I see no reason why additional cpu or platform-dependent would appear in normal.mod setjmp could even be put in a separate module but it's quite a waste because ELF overhead is much bigger then the module itself. Another possibility is ot compile it like ## common.rmk ## normal.mod: setjmp.lib normal_arch.lib: setjmp.S Vesa Jääskeläinen wrote: > phcoder wrote: >> Hello. I propose to create a symlink normal/cpu. This way normal.mod can >> be moved to conf/common.rmk. Works fine on i386-pc. Can people having >> other platforms test? > > I do not like the fact that you hardcoded filenames what can be on > platform dependant parts. > > I have also though this issue some times and I think the best option > would be: > > ## common.rmk ## > > normal.mod: normal_arch.lib > > ## arch.rmk ## > > normal_arch.lib: setjmp.S > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko