From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read CONFIG_SYS_MONITOR_LEN
Date: Mon, 23 Mar 2009 17:22:17 -0500 [thread overview]
Message-ID: <49C80B99.5010808@freescale.com> (raw)
In-Reply-To: <20090323220948.DCC74832E406@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Scott Wood,
>
> In message <20090323212514.GA30976@ld0162-tx32.am.freescale.net> you wrote:
>>> + /* Check for invalid block mark */
>>> + if (page < 2 && (onenand_readw(ONENAND_SPARERAM) != 0xffff))
>>> + return 1;
>> Unnecessary parens.
>
> Where? I find them pretty useful.
Around the second comparison. Why "if (a < b && (c != d))" and not "if
(a < b && c != d)", or if the parens are preferred, "if ((a < b) && (c
!= d))"? Is it because "c" is a function call?
> Please keep!
OK -- I guess this is another of the unwritten points on which U-boot's
style deviates from that which is typical in Linux.
-Scott
next prev parent reply other threads:[~2009-03-23 22:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 9:02 [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read CONFIG_SYS_MONITOR_LEN apgmoorthy
2009-03-23 21:25 ` Scott Wood
2009-03-23 22:09 ` Wolfgang Denk
2009-03-23 22:22 ` Scott Wood [this message]
2009-03-23 22:46 ` Wolfgang Denk
2009-03-25 4:13 ` Amit Kumar Sharma
2009-03-25 15:49 ` apgmoorthy
2009-03-27 9:15 ` apgmoorthy
2009-03-30 22:33 ` Scott Wood
2009-03-31 4:12 ` Amit Kumar Sharma
2009-03-31 16:08 ` Alessandro Rubini
2009-03-31 16:13 ` Scott Wood
2009-04-01 4:10 ` Amit Kumar Sharma
2009-04-01 21:55 ` Scott Wood
2009-04-12 7:55 ` apgmoorthy
2009-04-23 22:39 ` Scott Wood
2009-04-24 5:05 ` Amit Kumar Sharma
2009-04-13 13:04 ` [U-Boot] [PATCH] Bad Block Capable environment for OneNAND apgmoorthy
2009-04-28 23:11 ` Scott Wood
2009-04-06 6:05 ` [U-Boot] OneNand support broken for apollon apgmoorthy
[not found] <22617689.32781240550892435.JavaMail.weblogic@epml08>
2009-04-24 5:57 ` [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read CONFIG_SYS_MONITOR_LEN Kyungmin Park
2009-04-24 15:21 ` Scott Wood
2009-04-24 21:47 ` Jean-Christophe PLAGNIOL-VILLARD
-- strict thread matches above, loose matches on Subject: below --
2009-03-09 14:15 Rohit Hagargundgi
2009-03-09 19:42 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C80B99.5010808@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.