From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init()
Date: Tue, 24 Mar 2009 09:38:04 +0100 [thread overview]
Message-ID: <49C89BEC.6050100@denx.de> (raw)
In-Reply-To: <9e4733910903221955h4a6b3c24t34cce6989911be21@mail.gmail.com>
Hello Jon,
Jon Smirl wrote:
> On Sun, Mar 22, 2009 at 11:23 AM, Wolfgang Denk <wd@denx.de> wrote:
>
>> Dear Jon Smirl,
>>
>> In message <9e4733910903220723u31546286q233c9b24b7a5d53@mail.gmail.com> you wrote:
>>
>>> Would it be better to put the check for (gd->have_console) into printf itself?
>>>
>> No, as you could also use puts() or putc(). There are only a few
>> isolated places where we need this, so let's make this clearly
>> visible there.
>>
>
> mpc5200 with eeprom, suppress printf until console initialized
>
> From: Jon Smirl <jonsmirl@gmail.com>
>
> On boards which have the environment in eeprom, i2c_init()
> is called before the console and ram is initialized. Suppress
> printfs until the console is initialized.
>
> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
> ---
> cpu/mpc5xxx/i2c.c | 30 ++++++++++++++++++++----------
> 1 files changed, 20 insertions(+), 10 deletions(-)
>
Acked-by: Heiko Schocher <hs@denx.de>
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-03-24 8:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-21 13:38 [U-Boot] [PATCH 0/3] Three mpc5200 patches from Pengutronix.de Jon
2009-03-21 13:38 ` [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init() Jon
2009-03-21 19:47 ` Wolfgang Denk
2009-03-21 20:39 ` Jon Smirl
2009-03-21 20:54 ` Wolfgang Denk
2009-03-21 20:56 ` Wolfgang Denk
2009-03-22 14:01 ` Jon Smirl
2009-03-22 14:21 ` Wolfgang Denk
2009-03-22 14:23 ` Jon Smirl
2009-03-22 15:23 ` Wolfgang Denk
2009-03-23 2:55 ` Jon Smirl
2009-03-24 8:38 ` Heiko Schocher [this message]
2009-03-25 21:51 ` Wolfgang Denk
2009-03-25 22:31 ` Jon Smirl
2009-03-21 13:38 ` [U-Boot] [PATCH 2/3] mpc52xx phy: initialize only when needed Jon
2009-03-25 19:12 ` Jon Smirl
2009-03-25 21:53 ` Wolfgang Denk
2009-03-31 1:04 ` Jon Smirl
2009-03-31 6:13 ` Ben Warren
2009-04-04 20:37 ` Wolfgang Denk
2009-03-21 13:38 ` [U-Boot] [PATCH 3/3] mpc5200: make i2c faster Jon
2009-03-21 19:48 ` Wolfgang Denk
2009-03-22 14:20 ` Jon Smirl
2009-03-22 15:21 ` Wolfgang Denk
2009-03-23 2:59 ` Jon Smirl
2009-03-23 8:24 ` Wolfgang Denk
2009-03-22 23:16 ` Sascha Hauer
2009-03-23 3:00 ` Grant Likely
2009-03-23 6:24 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C89BEC.6050100@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.