From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LmDP2-00065l-S1 for mharc-grub-devel@gnu.org; Tue, 24 Mar 2009 16:39:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LmDP0-00065N-Km for grub-devel@gnu.org; Tue, 24 Mar 2009 16:39:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LmDOv-000648-51 for grub-devel@gnu.org; Tue, 24 Mar 2009 16:39:13 -0400 Received: from [199.232.76.173] (port=56771 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LmDOu-000645-Uo for grub-devel@gnu.org; Tue, 24 Mar 2009 16:39:08 -0400 Received: from mailout07.t-online.de ([194.25.134.83]:52851) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LmDOu-0000vS-GU for grub-devel@gnu.org; Tue, 24 Mar 2009 16:39:08 -0400 Received: from fwd03.aul.t-online.de by mailout07.sul.t-online.de with smtp id 1LmDOs-0000B9-01; Tue, 24 Mar 2009 21:39:06 +0100 Received: from [10.3.2.2] (r497iiZOohtJNOuyulrgBBwwlntIicswET+w3XzhUwnr3aBy3wfZ5mNW58MoiPPwIm@[217.235.222.19]) by fwd03.aul.t-online.de with esmtp id 1LmDOr-07fAVk0; Tue, 24 Mar 2009 21:39:05 +0100 Message-ID: <49C944EA.202@t-online.de> Date: Tue, 24 Mar 2009 21:39:06 +0100 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11 MIME-Version: 1.0 To: The development of GRUB 2 References: <20090313192016.GD17068@thorin> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: r497iiZOohtJNOuyulrgBBwwlntIicswET+w3XzhUwnr3aBy3wfZ5mNW58MoiPPwIm X-TOI-MSGID: 91292b81-06e8-4dfa-a7a3-39a8e6631920 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: precision formatting in grub_printf X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2009 20:39:14 -0000 Deepak Vankadaru wrote: > Hi, > > There was a redundant piece of code in the diff file I sent earlier. I > have removed it and prepared another patch file. I am attaching the > same. Please use this one instead. > > Following is the changelog. > > Changelog: > 2008-08-17 Deepak Vankadaru > > > Support for precision formatting in grub_printf > > * kern/misc.c: modified grub_vsprintf to parse and handle > precision formatting > Thanks. Unfortunately, the patch can no longer be applied to current svn without a conflict. The precision parsing and '%s' precision (truncation) handling is already implemented. But the '%d' precision (zero fill) handling part of your patch is still missing in the code. Could you please repost an updated patch in diff -u format? Note that the current code does not use a format2_default flag buts sets format2 to ~0U ('infinite' :-) if no precision is specified. Thanks -- Christian Franke