From: Jeff Garzik <jeff@garzik.org>
To: David Milburn <dmilburn@redhat.com>
Cc: linux-ide@vger.kernel.org, kristen.c.accardi@intel.com
Subject: Re: [PATCH] libata: ahci enclosure save new led state
Date: Tue, 24 Mar 2009 22:43:05 -0400 [thread overview]
Message-ID: <49C99A39.4090903@garzik.org> (raw)
In-Reply-To: <20090320191423.GA16289@dhcp-210.hsv.redhat.com>
David Milburn wrote:
> ahci_transmit_led_message saves off the led_state
> with a value that includes the port number OR'd
> in, this incorrect value maybe reported back
> in ahci_led_store.
>
> For instance, if you turn off all the leds for
> port 1 and cat the value back it will report 1
> instead of 0.
>
> # echo 0 > /sys/class/scsi_host/host1/em_message
> # cat /sys/class/scsi_host/host1/em_message
> 1
>
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> ---
> drivers/ata/ahci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied
prev parent reply other threads:[~2009-03-25 2:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 19:14 [PATCH] libata: ahci enclosure save new led state David Milburn
2009-03-25 2:43 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C99A39.4090903@garzik.org \
--to=jeff@garzik.org \
--cc=dmilburn@redhat.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.