All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Novotny <minovotn@redhat.com>
To: xen-devel@lists.xensource.com
Subject: Xen domain save file should be deleted/renamed after successful restore operation
Date: Wed, 25 Mar 2009 10:13:32 +0100	[thread overview]
Message-ID: <49C9F5BC.50602@redhat.com> (raw)

Hello everybody,
I have found a problem about the checkpoint file (saved domain file) 
that has been already used to restore a domain. The second time 
restoring domain from the same saved domain file will result in disk 
corruption and kernel of VM saved in this save file is in an 
inconsistent state then.

You can replicate this by eg. creating some PV domain, saving it using 
`xm save` command to /var/lib/xen/save directory and restoring it again. 
The domain save file is not deleted or anything so when rebooting dom0 
`xendomains` script starts this machine again but this results in disk 
corruption of disk used for this guest.

It would be better if we either delete a domain save file after 
successful restore process or at least rename it to some name that won't 
be run automatically using `xendomains` script (maybe we can append a 
dot before file name itself so it won't be restored automatically by 
this script) or, maybe better, there could be an option in 
xend-config.sxp to allow user choose what he would like to do.

Thanks,
Michal

             reply	other threads:[~2009-03-25  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25  9:13 Michal Novotny [this message]
2009-03-25 11:56 ` Xen domain save file should be deleted/renamed after successful restore operation Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C9F5BC.50602@redhat.com \
    --to=minovotn@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.