Re: nftables-goes-automake patch series

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> Not much more to elaborate on, this was straight forward to do
> and only a matter of time, and really needed :)
>
>  20 files changed, 145 insertions(+), 455 deletions(-)
>
> It is available too from  git://dev.medozas.de/nftables master
>
> Awaiting comments.

Patch 1 looks fine, although I might take the liberty to rename the
file again :)

About automake - I'm glad you're fixing up the makefiles, but I'm
quite attached to the silent build and the automake version that
comes with Debian unstable is 1.10, so I assume it won't be
silent anymore. It also doesn't build anymore on my system, the
parser.h file is not generated:

make  all-recursive
make[1]: Entering directory `/tmp/nftables'
Making all in doc
make[2]: Entering directory `/tmp/nftables/doc'
make[2]: Für das Ziel »all« ist nichts zu tun.
make[2]: Leaving directory `/tmp/nftables/doc'
Making all in files/nftables
make[2]: Entering directory `/tmp/nftables/files/nftables'
make[2]: Für das Ziel »all« ist nichts zu tun.
make[2]: Leaving directory `/tmp/nftables/files/nftables'
Making all in src
make[2]: Entering directory `/tmp/nftables/src'
depbase=`echo scanner.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
        gcc -DHAVE_CONFIG_H -I. -I..    -D_FILE_OFFSET_BITS=64 
-D_REENTRANT -Wall -Waggregate-return    -Wbad-function-cast 
-Wcast-align -Wdeclaration-after-statement  -Werror -Wformat=2 
-Winit-self -Winline -Wmissing-declarations         
-Wmissing-format-attribute -Wmissing-prototypes         -Wshadow 
-Wsign-compare -Wstrict-prototypes -Wundef -Wunused    -Wwrite-strings 
-fno-strict-aliasing -pipe -I../include 
-DDEFAULT_INCLUDE_PATH=\"/usr/local/etc/nftables\" -g -O2 -MT scanner.o 
-MD -MP -MF $depbase.Tpo -c -o scanner.o scanner.c &&\
        mv -f $depbase.Tpo $depbase.Po
scanner.l:23:20: Fehler: parser.h: Datei oder Verzeichnis nicht gefunden
<stdout>:1395: Fehler: expected specifier-qualifier-list before »YYSTYPE«
<stdout>:1454: Fehler: expected »=«, »,«, »;«, »asm« or »__attribute__« 
before »*« token...

About -Wshadow: in my experience it usually at some point becomes a nuisance
and starts causing strange naming. But for now I'm willing to try, your fix
looks simple enough.


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html