From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] fix question if lvconverting to core log
Date: Wed, 25 Mar 2009 14:33:50 +0100 [thread overview]
Message-ID: <49CA32BE.5090409@redhat.com> (raw)
yes_no_prompt returns 'n' or 'y'...
Why we require this always? My test case is that PV with log
fails.
Why it need resync before conversion to core log for
inactive mirror?
Signed-off-by: Milan Broz <mbroz@redhat.com>
diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c
index 304a8d9..8299c4d 100644
--- a/lib/metadata/mirror.c
+++ b/lib/metadata/mirror.c
@@ -1222,7 +1222,7 @@ int remove_mirror_log(struct cmd_context *cmd,
return 0;
} else if (yes_no_prompt("Full resync required to convert "
"inactive mirror %s to core log. "
- "Proceed? [y/n]: "))
+ "Proceed? [y/n]: ") == 'y')
sync_percent = 0;
else
return 0;
reply other threads:[~2009-03-25 13:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CA32BE.5090409@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.