All of lore.kernel.org
 help / color / mirror / Atom feed
From: Coly Li <coly.li@suse.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Randy Dunlap <randy.dunlap@oracle.com>
Subject: [PATCH] reiserfs: select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry
Date: Thu, 26 Mar 2009 00:58:06 +0800	[thread overview]
Message-ID: <49CA629E.7040701@suse.de> (raw)

In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm), crc32_le()
is referenced. If reiserfs is compiled into kernel and crc32_le() is compiled as
kernel module, there might be a compiling error as:
    fs/built-in.o: In function `reiserfs_statfs':
    super.c:(.text+0x7332b): undefined reference to `crc32_le'
    super.c:(.text+0x7333f): undefined reference to `crc32_le'
This patch select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry, which
indicates compiling crc32_le() into kernel.

Thanks to Randy Dunlap for pointing out this error and providing helpful solution.

Signed-off-by: Coly Li <coly.li@suse.de>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
 fs/reiserfs/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/reiserfs/Kconfig b/fs/reiserfs/Kconfig
index 949b8c6..9712bea 100644
--- a/fs/reiserfs/Kconfig
+++ b/fs/reiserfs/Kconfig
@@ -1,5 +1,7 @@
 config REISERFS_FS
 	tristate "Reiserfs support"
+	select CRC32
+	select BITREVERSE
 	help
 	  Stores not just filenames but the files themselves in a balanced
 	  tree.  Uses journalling.
-- 
Coly Li
SuSE Labs

             reply	other threads:[~2009-03-25 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 16:58 Coly Li [this message]
2009-03-25 17:07 ` [PATCH] reiserfs: select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry Randy Dunlap
2009-03-25 17:22   ` Coly Li
2009-03-27  8:28   ` Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CA629E.7040701@suse.de \
    --to=coly.li@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.