All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Anthony Liguori <anthony@codemonkey.ws>, KVM list <kvm@vger.kernel.org>
Subject: Re: Split kvm source tarballs
Date: Wed, 25 Mar 2009 20:02:48 +0200	[thread overview]
Message-ID: <49CA71C8.3000407@redhat.com> (raw)
In-Reply-To: <20090325164707.GA16225@infradead.org>

Christoph Hellwig wrote:
> On Wed, Mar 25, 2009 at 08:44:58AM -0500, Anthony Liguori wrote:
>   
>> That's what I figured.  FWIW, the split tarballs work just fine for me.
>>
>> It may be worth waiting to do step 2 until the IO thread is merged.  I  
>> think once that happens, we could probably do a sprint to get rid of  
>> libkvm in kvm-userspace.  That would certainly simplify things.
>>     
>
> Yeah.  And having the both common and split repos just confuses the
> heck out of any user of the repository.  I think the right way to split
> it to wait for libkvm going away and just have a qemu-kvm repository
> and an entirely separate kernel module repository.  It's not like there
> is anything common but the few exported ABI headers, and we can either
> keep them in both (would mean qemu-kvm can always build against a
> defined set of headers) or make qemu-kvm require a kernel source like
> the current kvm support in upstream qemu.
>   

While I strongly dislike duplicating code under source control, I'm 
beginning to lean in this direction, since the situation is beginning to 
confuse me too.

So how about this:

- keep copies of the headers in the qemu repository. 'make sync' becomes 
a maintainer tool rather than a developer tool
- move qemu to the root of the repository, and reparent libkvm/ user/ 
and friends under it.  this will give us easier merging.
- move the external module kit into kvm.git

We end up with a standalone kvm-userspace.git which is easily mergable 
to and from qemu.git, and kvm.git which can build either a Linux kernel 
(and is easily mergable to and from Linus' tree and others) or an 
external module.

No git submodules or inter-repository dependencies.  What's not to like?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2009-03-25 18:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 14:21 Split kvm source tarballs Avi Kivity
2009-03-25 13:18 ` Anthony Liguori
2009-03-25 13:23   ` Avi Kivity
2009-03-25 13:44     ` Anthony Liguori
2009-03-25 16:47       ` Christoph Hellwig
2009-03-25 18:02         ` Avi Kivity [this message]
2009-03-25 18:17           ` Christoph Hellwig
2009-03-26  9:09             ` Avi Kivity
2009-03-26 22:48               ` Christoph Hellwig
2009-04-16 20:17               ` Christoph Hellwig
2009-04-18 22:13                 ` Anthony Liguori
2009-04-19  8:26                 ` Avi Kivity
2009-03-25 21:34     ` Anthony Liguori
2009-03-26  8:57       ` Christoph Hellwig
2009-03-26 18:19         ` Anthony Liguori
2009-03-26 22:48           ` Christoph Hellwig
2009-03-27  2:44             ` Anthony Liguori
2009-03-26 10:09       ` Avi Kivity
2009-03-26 18:19         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CA71C8.3000407@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=hch@infradead.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.