From: Patrick McHardy <kaber@trash.net>
To: Holger Eitzenberger <holger@eitzenberger.org>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [patch 1/3] ctnetlink: allocate right-sized ctnetlink skb
Date: Wed, 25 Mar 2009 21:51:50 +0100 [thread overview]
Message-ID: <49CA9966.9010205@trash.net> (raw)
In-Reply-To: <20090325204600.456638455@jonathan.eitzenberger.org>
Holger Eitzenberger wrote:
> Try to allocate a Netlink skb roughly the size of the actual
> message, with the help from the l3 and l4 protocol helpers.
> This is all to prevent a reallocation in netlink_trim() later.
>
> The overhead of allocating the right-sized skb is rather small, with
> ctnetlink_alloc_skb() actually being inlined away on my x86_64 box.
> The size of the per-proto space is determined at registration time of
> the protocol helper.
Applied, thanks.
next prev parent reply other threads:[~2009-03-25 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 20:34 [patch 0/3] ctnetlink: allocation improvements Holger Eitzenberger
2009-03-25 20:34 ` [patch 1/3] ctnetlink: allocate right-sized ctnetlink skb Holger Eitzenberger
2009-03-25 20:51 ` Patrick McHardy [this message]
2009-03-25 20:34 ` [patch 2/3] netfilter: add generic function to get len of generic policy Holger Eitzenberger
2009-03-25 20:53 ` Patrick McHardy
2009-03-25 20:34 ` [patch 3/3] netfilter: calculate per-protocol nlattr size Holger Eitzenberger
2009-03-25 20:54 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CA9966.9010205@trash.net \
--to=kaber@trash.net \
--cc=holger@eitzenberger.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.