From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Steven Rostedt <srostedt@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] trace_stat: keep original order
Date: Thu, 26 Mar 2009 10:19:55 +0800 [thread overview]
Message-ID: <49CAE64B.4020707@cn.fujitsu.com> (raw)
In-Reply-To: <1237991798.22033.7.camel@localhost.localdomain>
Steven Rostedt wrote:
> On Wed, 2009-03-25 at 16:58 +0800, Lai Jiangshan wrote:
>> Impact: make trace_stat files show items with the original order
>>
>> trace_stat tracer reverse the items, it makes the output
>> looks a little ugly.
>>
>> Example, when we read trace_stat/workqueues, we get cpu#7's stat.
>> at first, and then cpu#6... cpu#0.
>>
>
> This doesn't reverse the order of the annotated branch profiler, does
> it?
>
The annotated ftrace_branch_data are orderless. So it's OK
with or without this fix.
(From code, not test) If this fix applied,
__start_annotated_branch_profile is shown at the first, and then
__start_annotated_branch_profile + 1... and
__stop_annotated_branch_profile is shown at the last.
Lai
next prev parent reply other threads:[~2009-03-26 2:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 8:58 [PATCH 1/2] trace_stat: keep original order Lai Jiangshan
2009-03-25 13:30 ` Frederic Weisbecker
2009-03-25 14:36 ` Steven Rostedt
2009-03-26 2:19 ` Lai Jiangshan [this message]
2009-03-25 17:33 ` [tip:tracing/ftrace] " Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CAE64B.4020707@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.