All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Tejun Heo <htejun@gmail.com>
Cc: bzolnier@gmail.com, linux-kernel@vger.kernel.org,
	axboe@kernel.dk, linux-ide@vger.kernel.org
Subject: Re: [PATCH 03/14] block: implement blk_rq_map_kern_prealloc()
Date: Thu, 26 Mar 2009 10:10:34 +0200	[thread overview]
Message-ID: <49CB387A.3000006@panasas.com> (raw)
In-Reply-To: <49CB3765.4070406@panasas.com>

On 03/26/2009 10:05 AM, Boaz Harrosh wrote:
> On 03/26/2009 09:42 AM, Tejun Heo wrote:
>> The thing is that the prealloc variant should be allowed to be called
>> from IRQ context and blk_queue_bounce() shouldn't be called.
>> Hmmm... well, the caller is supposed to know what it's doing and maybe
>> we can just add a comment that it shouldn't be called with buffers
>> which might get bounced from IRQ context.
>>
> 
> Hmm that is a problem. I would suggest a flag or a check. My bios come
> from VFS they need bouncing.
> 
> Can you think of a solution?
> 
> We could just call blk_queue_bounce(). IRQ callers need to make sure their
> buffers don't need bouncing anyway, so there is no such bug right? If a programmer
> gets it wrong he will get a BUG check that tells him that.
> 

I just realized that in your original call you had the "force" flag, we can keep
that flag for the blk_rq_set_bio(), or what ever we should name it.

Thanks
Boaz

  reply	other threads:[~2009-03-26  8:12 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24 16:06 [PATCHSET pata-2.6] ide: rq->buffer, data, special and misc cleanups Tejun Heo
2009-03-24 16:06 ` [PATCH 01/14] block: clear req->errors on bio completion only for fs requests Tejun Heo
2009-03-24 16:06 ` [PATCH 02/14] block: reorganize [__]bio_map_kern() Tejun Heo
2009-03-24 16:06 ` [PATCH 03/14] block: implement blk_rq_map_kern_prealloc() Tejun Heo
2009-03-25 15:18   ` Boaz Harrosh
2009-03-26  2:10     ` Tejun Heo
2009-03-26  7:42       ` Tejun Heo
2009-03-26  8:05         ` Boaz Harrosh
2009-03-26  8:10           ` Boaz Harrosh [this message]
2009-03-26 10:19             ` Tejun Heo
2009-03-26 11:23               ` Boaz Harrosh
2009-03-26 12:07                 ` Tejun Heo
2009-03-26 14:44                   ` Boaz Harrosh
2009-03-27  2:26                     ` Tejun Heo
2009-04-13 10:07           ` FUJITA Tomonori
2009-03-24 16:06 ` [PATCH 04/14] ide: use blk_run_queue() instead of blk_start_queueing() Tejun Heo
2009-03-24 16:06 ` [PATCH 05/14] ide: don't set REQ_SOFTBARRIER Tejun Heo
2009-03-24 16:06 ` [PATCH 06/14] ide kill unused ide_cmd->special Tejun Heo
2009-03-24 16:06 ` [PATCH 07/14] ide-cd: clear sense buffer before issuing request sense Tejun Heo
2009-03-26  7:20   ` Borislav Petkov
2009-03-26  7:26     ` Tejun Heo
2009-03-24 16:06 ` [PATCH 08/14] ide-floppy: block pc always uses bio Tejun Heo
2009-03-24 16:06 ` [PATCH 09/14] ide-taskfile: don't abuse rq->buffer Tejun Heo
2009-03-24 16:06 ` [PATCH 10/14] ide-atapi: " Tejun Heo
2009-03-24 16:06 ` [PATCH 11/14] ide-cd: " Tejun Heo
2009-03-26  8:34   ` Borislav Petkov
2009-03-24 16:06 ` [PATCH 12/14] ide-pm: don't abuse rq->data Tejun Heo
2009-03-24 16:06 ` [PATCH 13/14] ide-atapi: use bio for request sense Tejun Heo
2009-03-28  8:43   ` Borislav Petkov
2009-03-24 16:06 ` [PATCH 14/14] ide-cd: " Tejun Heo
2009-04-13  8:52   ` Borislav Petkov
2009-03-28 13:51 ` [PATCHSET pata-2.6] ide: rq->buffer, data, special and misc cleanups Bartlomiej Zolnierkiewicz
2009-03-28 14:04   ` Borislav Petkov
2009-03-30  9:12     ` Tejun Heo
2009-03-30 11:14       ` Boaz Harrosh
2009-03-30 17:20         ` Tejun Heo
2009-03-31  8:43           ` Boaz Harrosh
2009-03-31  9:05             ` Tejun Heo
2009-03-31  9:10               ` Tejun Heo
2009-03-31 13:04               ` Boaz Harrosh
2009-03-31 13:43                 ` Tejun Heo
2009-04-01 11:50                   ` Boaz Harrosh
2009-04-13  7:41                 ` FUJITA Tomonori
2009-04-13  7:54                   ` Jeff Garzik
2009-04-13  8:22                     ` FUJITA Tomonori
2009-04-13  8:31                       ` Jeff Garzik
2009-04-13 10:07                         ` FUJITA Tomonori
2009-04-13 14:16                         ` James Bottomley
2009-03-30 14:50       ` Bartlomiej Zolnierkiewicz
2009-03-30 14:50         ` Bartlomiej Zolnierkiewicz
2009-03-30 17:21         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CB387A.3000006@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=axboe@kernel.dk \
    --cc=bzolnier@gmail.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.