From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] blktrace: make classic output more classic
Date: Fri, 27 Mar 2009 11:30:46 +0800 [thread overview]
Message-ID: <49CC4866.5050604@cn.fujitsu.com> (raw)
In-Reply-To: <49CC37C2.7050307@cn.fujitsu.com>
> @@ -995,7 +995,7 @@ static int blk_log_action_iter(struct trace_iterator *iter, const char *act)
> {
> char rwbs[6];
> unsigned long long ts = ns2usecs(iter->ts);
This should be changed to "ts = iter->ts".
I'll fix it and resend the patchset, since this affects a later patch.
> - unsigned long usec_rem = do_div(ts, USEC_PER_SEC);
> + unsigned long nsec_rem = do_div(ts, NSEC_PER_SEC);
> unsigned secs = (unsigned long)ts;
> const struct trace_entry *ent = iter->ent;
> const struct blk_io_trace *t = (const struct blk_io_trace *)ent;
> @@ -1003,9 +1003,9 @@ static int blk_log_action_iter(struct trace_iterator *iter, const char *act)
> fill_rwbs(rwbs, t);
next prev parent reply other threads:[~2009-03-27 3:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 2:19 [PATCH 0/6] blktrace: last round of fixes Li Zefan
2009-03-27 2:19 ` [PATCH 1/6] blktrace: make classic output more classic Li Zefan
2009-03-27 3:30 ` Li Zefan [this message]
2009-03-28 21:27 ` [tip:tracing/blktrace] " Li Zefan
2009-03-30 1:19 ` Li Zefan
2009-03-27 2:20 ` [PATCH 2/6] blktrace: fix blk_probes_ref chaos Li Zefan
2009-03-28 21:28 ` [tip:tracing/blktrace] " Li Zefan
2009-03-30 1:19 ` Li Zefan
2009-03-27 2:20 ` [PATCH 3/6] blktrace: fix memory leak when freeing struct blk_io_trace Li Zefan
2009-03-28 21:28 ` [tip:tracing/blktrace] " Li Zefan
2009-03-30 1:19 ` Li Zefan
2009-03-27 2:21 ` [PATCH 4/6] trace: make argument 'mem' of trace_seq_putmem() const Li Zefan
2009-03-28 21:28 ` [tip:tracing/blktrace] " Li Zefan
2009-03-30 1:20 ` Li Zefan
2009-03-27 2:21 ` [PATCH 5/6] blktrace: extract duplidate code Li Zefan
2009-03-28 21:28 ` [tip:tracing/blktrace] " Li Zefan
2009-03-30 1:20 ` Li Zefan
2009-03-27 2:21 ` [PATCH 6/6] blktrace: print out BLK_TN_MESSAGE properly Li Zefan
2009-03-28 21:28 ` [tip:tracing/blktrace] " Li Zefan
2009-03-30 1:20 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CC4866.5050604@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.