From: Eric Sandeen <sandeen@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: tytso@mit.edu, adilger@sun.com, linux-ext4@vger.kernel.org
Subject: Re: [patch] ext4: typo leads to small leak
Date: Fri, 27 Mar 2009 09:13:29 -0500 [thread overview]
Message-ID: <49CCDF09.3020804@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0809291437490.14101@usbsys.site>
Dan Carpenter wrote:
> This was found by smatch (http://repo.or.cz/w/smatch.git/)
>
> regards,
> dan carpenter
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Thanks! Maybe one for the stable trees.
> --- orig/fs/ext4/mballoc.c 2009-03-26 18:22:30.000000000 +0300
> +++ devel/fs/ext4/mballoc.c 2009-03-26 18:22:56.000000000 +0300
> @@ -2693,7 +2693,7 @@
> i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int);
> sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL);
> if (sbi->s_mb_maxs == NULL) {
> - kfree(sbi->s_mb_maxs);
> + kfree(sbi->s_mb_offsets);
> return -ENOMEM;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-03-27 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:36 [patch] ext4: typo leads to small leak Dan Carpenter
2009-03-27 14:13 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CCDF09.3020804@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger@sun.com \
--cc=error27@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.