From: Larry Finger <Larry.Finger@lwfinger.net>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Li Zefan <lizf@cn.fujitsu.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: Possible IRQ lock inversion from 2.6.29-Linus-03321-gbe0ea69 (2.6.29-git)
Date: Fri, 27 Mar 2009 14:05:02 -0500 [thread overview]
Message-ID: <49CD235E.7030404@lwfinger.net> (raw)
In-Reply-To: <20090327120623.3056c795@bike.lwn.net>
Jonathan Corbet wrote:
>
> We could do that. When I made the change I'd verified that there were
> no users in IRQ context, and I couldn't really see why there should
> be. I'd rather avoid adding all those IRQ disables if I can avoid it.
>
> How about, instead, just reversing the order of lock acquisition in
> fasync_helper()? That would increase the hold time for f_lock, but I
> have a hard time seeing that being a real problem. I'm running with
> the following now; all seems well. I'll send it up in a bit if nobody
> gripes.
The patch gets rid of the warning for me.
Larry
next prev parent reply other threads:[~2009-03-27 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 5:07 Possible IRQ lock inversion from 2.6.29-Linus-03321-gbe0ea69 (2.6.29-git) Larry Finger
2009-03-27 12:54 ` Bartlomiej Zolnierkiewicz
2009-03-27 18:06 ` Jonathan Corbet
2009-03-27 19:05 ` Larry Finger [this message]
2009-03-28 0:32 ` Peter Zijlstra
2009-03-28 13:36 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CD235E.7030404@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bzolnier@gmail.com \
--cc=corbet@lwn.net \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.