From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/2] Fix immediate error handling on synthetic aios
Date: Sat, 28 Mar 2009 11:11:55 -0500 [thread overview]
Message-ID: <49CE4C4B.4010403@us.ibm.com> (raw)
In-Reply-To: <1238160630-8745-1-git-send-email-avi@redhat.com>
Avi Kivity wrote:
> The block layer can signal aio errors in two ways: by calling the completion
> function with a negative status code, or by returning a NULL aiocb. Two of
> the synthetic aio implementations (the DMA API and the vectored aio bouncing)
> fail to handle the second case correctly, resulting in crashes when
> cancellation of a timed out request is attempted.
>
> I think the long term fix is to have the block layer signal errors in just
> one way -- by invoking the completion handler with a negative return code --
> but in the meanwhile, here are patches that add the required error checking.
>
> Avi Kivity (2):
> Fix vectored aio bounce handling immediate errors
> Fix DMA API when handling an immediate error from block layer
>
> block.c | 5 +++++
> dma-helpers.c | 27 +++++++++++++++++++++------
> 2 files changed, 26 insertions(+), 6 deletions(-)
>
Applied all. Thanks.
Regards,
Anthony Liguori
prev parent reply other threads:[~2009-03-28 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 13:30 [Qemu-devel] [PATCH 0/2] Fix immediate error handling on synthetic aios Avi Kivity
2009-03-27 13:30 ` [Qemu-devel] [PATCH 1/2] Fix vectored aio bounce handling immediate errors Avi Kivity
2009-03-27 13:30 ` [Qemu-devel] [PATCH 2/2] Fix DMA API when handling an immediate error from block layer Avi Kivity
2009-03-28 16:11 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CE4C4B.4010403@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.