Re: [Qemu-devel] [PATCH] [STABLE] Clean some PCI defines

[Anthony Liguori <aliguori@us.ibm.com>]

Stefan Weil wrote:
> Hello,
>
> this patch adds some more defines from linux/pci_regs.h to
> hw/pci.h. There is now no longer a need to define them in
> eepro100.c, so they were removed there.
>
> Some defines from linux/pci_regs.h had similar, but not
> the same defines in hw/pci.h (PCI_REVISION_ID / PCI_REVISION,
> PCI_SUBSYSTEM_VENDOR_ID / PCI_SUBVENDOR_ID,
> PCI_SUBSYSTEM_ID / PCI_SUBDEVICE_ID).
>
> I suggest to use the "standard" from linux/pci_regs.h and
> replace the "old" Qemu ones. To facilitate the migration,
> my patch does not remove the old defines but marks them
> as obsolete. After a migration to the "standard" defines,
> pci.h could use linux/pci_regs.h which is far more complete.
>
> The patch is needed for an updated maintainer version of
> hw/eepro100.c which I'd like to see in Qemu stable.
>   

Applied to trunk.  Since this isn't a bug fix, I don't think it's 
appropriate for stable.  If you have another bug fix in your queue that 
depends on this patch, I'd rather that a simpler change be used.

Regards,

Anthony Liguori

> Regards
>
> Stefan Weil
>
>
>
>