From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1LnrVM-0005Li-8V
	for mharc-grub-devel@gnu.org; Sun, 29 Mar 2009 05:40:36 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LnrVI-0005LX-Ur
	for grub-devel@gnu.org; Sun, 29 Mar 2009 05:40:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LnrVC-0005LK-R8
	for grub-devel@gnu.org; Sun, 29 Mar 2009 05:40:32 -0400
Received: from [199.232.76.173] (port=46846 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LnrVC-0005LH-Gq
	for grub-devel@gnu.org; Sun, 29 Mar 2009 05:40:26 -0400
Received: from mta-out.inet.fi ([195.156.147.13]:33549 helo=kirsi1.inet.fi)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <chaac@nic.fi>) id 1LnrVC-0006KJ-2s
	for grub-devel@gnu.org; Sun, 29 Mar 2009 05:40:26 -0400
Received: from [192.168.1.102] (84.248.105.254) by kirsi1.inet.fi (8.5.014)
	id 49CA1E7300279AAC for grub-devel@gnu.org;
	Sun, 29 Mar 2009 12:40:21 +0300
Message-ID: <49CF4200.7010500@nic.fi>
Date: Sun, 29 Mar 2009 12:40:16 +0300
From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= <chaac@nic.fi>
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <ca0f59980903290225u784b2421u5a50a9822ae27c7d@mail.gmail.com>
In-Reply-To: <ca0f59980903290225u784b2421u5a50a9822ae27c7d@mail.gmail.com>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: [PATCH] Split of the normal mode
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Mar 2009 09:40:34 -0000

Bean wrote:
> Hi,
> 
> This patch split the function of normal mode into small modules, here
> is a summary:
> 
> 1, Move dynamic command loader to commands/dyncmd.c (dyncmd.mod)
> 2, Move automatic fs loader to fs/autofs.c (autofs.mod)
> 3, Split normal mode into three major parts:
> parser/normal - normal mode parser (nparser.mod)
> reader/normal - normal mode command line reader (nreader.mod)
> menu/text - menu viewer (tmenu.mod)
> 4, Generic menu function move to menu/menu.c and menu/menu_viewer.c. (menu.mod)
> 5, Misc function move to lib/misc.c lib/completion.c (misc.mod)
> 6, setjmp function move to lib/i386, lib/x86_64, lib/powerpc and
> lib/sparc64 (setjmp.mod)

Umh... I could somewhat agree with moving text menu out of normal.mod.
But...

I feel we have passed the over engineering milestone sometime ago... and
 I am not frankly happy about that...

Changes like this just make it a) harder to maintain, b) bigger overall
size impact, c) as a plus more modular approach...

I also fear that we seem to be missing some lead for the project that
could use his authority to make decisions...