From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH 0/6] Alchemy updates for 2.6.30
Date: Sun, 29 Mar 2009 15:02:21 +0400 [thread overview]
Message-ID: <49CF553D.7070903@ru.mvista.com> (raw)
In-Reply-To: <1237999773-5174-1-git-send-email-mano@roarinelk.homelinux.net>
Hello.
Manuel Lauss wrote:
> Here is another set of patches which aim to improve Alchemy and DB1200 support.
> (doesn't apply against Kevin Hickey's DB1300 patches)
>
[...]
> #5 I dislike the alchemy/common/platform.c file because it makes passing
> platform data to drivers ugly (the platdata struct and the consumer
> are in different files)
>
I think it's rather smart scheme -- prevents duplication. Please
don't change it.
> and I also don't like the fact that every conceivable piece of alchemy hardware has a driver registered whether I like it or not.
Only platform device, not the driver. User entirely controls what
drivers are built.
> To not change existing behaviour, the platform.c file is now invoked by the board Makefiles instead of the one in common/.
WBR, Sergei
prev parent reply other threads:[~2009-03-29 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 16:49 [PATCH 0/6] Alchemy updates for 2.6.30 Manuel Lauss
2009-03-25 16:49 ` [PATCH 1/6] Alchemy: unify CPU model constants Manuel Lauss
2009-03-25 16:49 ` [PATCH 2/6] Alchemy: provide cpu feature overrides Manuel Lauss
2009-03-25 16:49 ` [PATCH 3/6] Alchemy: MIPS hazard workarounds are not required Manuel Lauss
2009-03-25 16:49 ` [PATCH 4/6] Alchemy: PB1200: use SMC91X platform data Manuel Lauss
2009-03-25 16:49 ` [PATCH 5/6] Alchemy: don't unconditionally register all alchemy platform devices Manuel Lauss
2009-03-25 16:49 ` [PATCH 6/6] Alchemy: extended DB1200 board support Manuel Lauss
2009-03-29 11:04 ` [PATCH 5/6] Alchemy: don't unconditionally register all alchemy platform devices Sergei Shtylyov
2009-03-28 14:03 ` [PATCH 0/6] Alchemy updates for 2.6.30 Manuel Lauss
2009-03-28 16:50 ` Ralf Baechle
2009-03-29 11:02 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CF553D.7070903@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=mano@roarinelk.homelinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.