From: Avi Kivity <avi@redhat.com>
To: "Han, Weidong" <weidong.han@intel.com>
Cc: "'kvm@vger.kernel.org'" <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/2] kvm: qemu: check device assignment command
Date: Sun, 29 Mar 2009 17:35:02 +0300 [thread overview]
Message-ID: <49CF8716.4060300@redhat.com> (raw)
In-Reply-To: <715D42877B251141A38726ABF5CABF2C01A11B6AB9@pdsmsx503.ccr.corp.intel.com>
Han, Weidong wrote:
>> I suggest replacing the parsing code with pci_parse_devaddr() (needs
>> to be extended to support functions) so that all the checking and
>> parsing is done in one place.
>>
>
> If use pci_parse_devaddr(), it needs to add domain section to assigning command, and add function section to pci_add/pci_del commands. What's more, pci_parse_devaddr() parses guest device bdf, there are some assumption, such as function is 0. But here parse host bdf. It's a little complex to combine them together.
>
Right, but we end up with overall better code.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-03-29 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 9:02 [PATCH 2/2] kvm: qemu: check device assignment command Han, Weidong
2009-03-26 12:04 ` Avi Kivity
2009-03-27 9:31 ` Han, Weidong
2009-03-29 14:35 ` Avi Kivity [this message]
2009-03-30 12:41 ` Han, Weidong
2009-04-01 9:18 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CF8716.4060300@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=weidong.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.