From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6951] misc scsi disk/cdrom fixes/improvements 1/4
Date: Sun, 29 Mar 2009 14:14:26 -0500 [thread overview]
Message-ID: <49CFC892.8050006@codemonkey.ws> (raw)
In-Reply-To: <49CF9EBF.7050601@redhat.com>
Avi Kivity wrote:
> Blue Swirl wrote:
>> Log Message:
>> -----------
>> misc scsi disk/cdrom fixes/improvements 1/4
>>
>> Use correct sector size for cdrom Read TOC command
>>
>
> Meta-comment: in git of the log message, the first line is usually a
> summary of the commit; so if we're planning to switch to git, subjects
> like 'fixed content ?/n' are not helpful.
Regardless of git or not, it's useful when sending a patch series to
make the subject descriptive as opposed to a boiler plate 'series N/M'.
A CodingStyle/SubmittingPatches for QEMU would be rather useful.
Regards,
Anthony Liguori
prev parent reply other threads:[~2009-03-29 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 15:39 [Qemu-devel] [6951] misc scsi disk/cdrom fixes/improvements 1/4 Blue Swirl
2009-03-29 16:15 ` Avi Kivity
2009-03-29 19:14 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CFC892.8050006@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.