All of lore.kernel.org
 help / color / mirror / Atom feed
From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Leak fixes
Date: Sun, 29 Mar 2009 23:21:16 +0200	[thread overview]
Message-ID: <49CFE64C.10402@gmail.com> (raw)
In-Reply-To: <49C6429F.30604@gmail.com>

committed
phcoder wrote:
> Robert Millan wrote:
>> On Sun, Mar 22, 2009 at 02:09:52PM +0100, phcoder wrote:
>>>    -  grub_disk_cache_invalidate (dev_id, disk_id, sector);
>>> -     index = grub_disk_cache_get_index (dev_id, disk_id, sector);
>>>    cache = grub_disk_cache_table + index;
>>> + +  cache->lock = 1;
>>> +  grub_free (cache->data);
>>> +  cache->data = 0;
>>> +  cache->lock = 0;
>>
>> Does this imply grub_disk_cache_invalidate() is not working properly?  
>> Can it
>> be fixed instead?
>>
> No it works fine. But it's used to say to cache subsystem "block number 
> N on disk DISK" was updated. In this case when new block collides with 
> old one old one has to be freed even if it's still valid
> 


-- 

Regards
Vladimir 'phcoder' Serbinenko



      reply	other threads:[~2009-03-29 21:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-09 14:47 Leak fixes phcoder
2009-03-22 13:09 ` phcoder
2009-03-22 13:45   ` Robert Millan
2009-03-22 13:52     ` phcoder
2009-03-29 21:21       ` phcoder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CFE64C.10402@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.