From: Avi Kivity <avi@redhat.com>
To: "Dong, Eddie" <eddie.dong@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: Cleanup to reuse is_long_mode()
Date: Mon, 30 Mar 2009 10:43:20 +0300 [thread overview]
Message-ID: <49D07818.8050605@redhat.com> (raw)
In-Reply-To: <9832F13BD22FB94A829F798DA4A8280501A3C01E87@pdsmsx503.ccr.corp.intel.com>
Dong, Eddie wrote:
> struct vcpu_svm *svm = to_svm(vcpu);
>
> #ifdef CONFIG_X86_64
> - if (vcpu->arch.shadow_efer & EFER_LME) {
> + if (is_long_mode(vcpu)) {
>
is_long_mode() actually tests EFER_LMA, so this is incorrect.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-03-30 7:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9832F13BD22FB94A829F798DA4A8280501A21068EF@pdsmsx503.ccr.corp.intel.com>
2009-03-27 4:19 ` RFC: Add reserved bits check Dong, Eddie
2009-03-27 9:34 ` Avi Kivity
2009-03-27 13:46 ` Dong, Eddie
2009-03-27 13:59 ` Dong, Eddie
2009-03-27 14:28 ` Avi Kivity
2009-03-27 14:42 ` Dong, Eddie
2009-03-29 10:23 ` Avi Kivity
2009-03-30 1:53 ` Dong, Eddie
2009-03-30 2:38 ` Cleanup to reuse is_long_mode() Dong, Eddie
2009-03-30 7:43 ` Avi Kivity [this message]
2009-03-30 8:24 ` Dong, Eddie
2009-03-30 11:46 ` Avi Kivity
2009-03-30 2:49 ` Use rsvd_bits_mask in load_pdptrs for cleanup and considing EXB bit Dong, Eddie
2009-03-30 8:27 ` Dong, Eddie
2009-03-30 12:13 ` Avi Kivity
2009-03-30 13:46 ` Dong, Eddie
2009-03-30 5:12 ` RFC: Add reserved bits check Avi Kivity
2009-03-30 8:21 ` Dong, Eddie
2009-03-30 12:05 ` Avi Kivity
2009-03-31 8:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D07818.8050605@redhat.com \
--to=avi@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.