From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LoZls-0001jp-AD for mharc-grub-devel@gnu.org; Tue, 31 Mar 2009 04:56:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LoZlp-0001hg-8T for grub-devel@gnu.org; Tue, 31 Mar 2009 04:56:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LoZlk-0001cZ-Ik for grub-devel@gnu.org; Tue, 31 Mar 2009 04:56:32 -0400 Received: from [199.232.76.173] (port=33472 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LoZlk-0001cQ-Dx for grub-devel@gnu.org; Tue, 31 Mar 2009 04:56:28 -0400 Received: from mail-bw0-f167.google.com ([209.85.218.167]:42515) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LoZlj-0002iK-N2 for grub-devel@gnu.org; Tue, 31 Mar 2009 04:56:28 -0400 Received: by bwz11 with SMTP id 11so2159847bwz.42 for ; Tue, 31 Mar 2009 01:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=hZVPNd6/JzUAVA3frPyKE/XYlRZrkrpNKzJgNk4mloU=; b=EcCUruqVtL71XLPKVGBy20l0/BKUyGsCa6g9o95W8DXCpk8PSTYalKZXQ6RHVa44z4 m/ZLWFmMW+HOjZ47hKMbDIp/9wtUrxbyN2YGHKiaSkZm8lmcDeNEhYB34Sb63UW/foJA IZ/1NkZbHp88443TTVxpuwiws+ox7/3phnY1Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=d2aV1nPiRTNh7JCGP2aBxKWWPxMg3ZRtXM7TykNZoyWzOK07Qjm5p7dmFpa6fe7Pf3 +hSDqfDlQzVJTeZYd2NAQQEG+89lby3kBvkFdM0JThFUVctwh57raGD+Dfk6Euir0sXJ Kr7VNgl+3msuizS17JcaLhdhvqHM3CXZZ8Ti4= Received: by 10.223.114.74 with SMTP id d10mr4802279faq.87.1238489786026; Tue, 31 Mar 2009 01:56:26 -0700 (PDT) Received: from ?82.130.83.110? (hpx-public-dock-110-dhcp.ethz.ch [82.130.83.110]) by mx.google.com with ESMTPS id g28sm2754301fkg.18.2009.03.31.01.56.25 (version=SSLv3 cipher=RC4-MD5); Tue, 31 Mar 2009 01:56:25 -0700 (PDT) Message-ID: <49D1DAB8.90703@gmail.com> Date: Tue, 31 Mar 2009 10:56:24 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.21 (X11/20090318) MIME-Version: 1.0 To: The development of GRUB 2 References: <49C63395.9090304@gmail.com> In-Reply-To: <49C63395.9090304@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Move loader.c out of the kernel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2009 08:56:33 -0000 With a new swing in normal.mod splitting I think we should reconsider this patch. It's useless to keep loader.c in kernel without boot command. IMO it should be moved either to a perate boot.mod (my preference) or to minicmd.mod (not a good option IMO) phcoder wrote: > Hello. Now when boot command isn't in kernel anymore I don't see why > loader.c stays in kernel. Here is the patch to move it to boot.mod > 2009-03-22 Vladimir Serbinenko > > Move loader out of the kernel > > * kern/loader.c: moved to ... > * commands/boot.c: ... moved here > * commands/minicmd.c (grub_mini_cmd_boot): moved to ... > * commands/boot.c (grub_cmd_boot): moved here. All users updated > * include/grub/kernel.h (grub_machine_fini): export > * include/grub/loader.h (grub_loader_is_loaded): update declaration > (grub_loader_set): likewise > (grub_loader_unset): likewise > (grub_loader_boot): likewise > * conf/common.rmk: new module boot.mod > (pkglib_MODULES): add boot.mod > * conf/i386-coreboot.rmk (kernel_elf_SOURCES): remove kern/loader.c > (grub_emu_SOURCES): likewise > * conf/i386-efi.rmk (kernel_elf_SOURCES): likewise > (grub_emu_SOURCES): likewise > * conf/i386-ieee1275.rmk (kernel_elf_SOURCES): likewise > (grub_emu_SOURCES): likewise > * conf/i386-pc.rmk (kernel_elf_SOURCES): likewise > (grub_emu_SOURCES): likewise > * conf/powerpc-ieee1275.rmk (kernel_elf_SOURCES): likewise > (grub_emu_SOURCES): likewise > * conf/sparcs64-ieee1275.rmk (kernel_elf_SOURCES): likewise > (grub_emu_SOURCES): likewise > * conf/x86_64-efi.rmk (kernel_elf_SOURCES): likewise > (grub_emu_SOURCES): likewise > > -- Regards Vladimir 'phcoder' Serbinenko